Conversation
nathan-contino
left a comment
There was a problem hiding this comment.
Looking good, a few suggestions to make these changes even more readable.
| <Aside type="note"> | ||
| [FusionAuth FGA by Permify](/docs/extend/examples/modeling-hierarchies#fine-grained-authentication) is an alternative to using FusionAuth Entities to model hierarchical relationships. FusionAuth FGA by Permify is not available in the free version of FusionAuth. | ||
| </Aside> |
There was a problem hiding this comment.
Two asides in a row at the top of a page is a bit of a red flag to me. Can we move this into the "Fine-Grained Authentication" section below, instead? I think if we do that, we can likely get rid of the enterprise blurb you just put in that spot (also improves the flow, as consecutive asides break the flow a bit), but I'll leave that decision up to you.
There was a problem hiding this comment.
oh man, I really wanted to highlight Permify, but I hear you. Removed.
| } | ||
| ``` | ||
|
|
||
| FusionAuth FGA by Permify propagates permissions without any manual coordination or calculation. It also centralizes your authorization model. |
There was a problem hiding this comment.
Doesn't the previous example also centralize the auth model? I think we can get rid of that sentence and instead focus on the 'propagates' selling point here, which (iiuc) is a better way of distinguishing this approach anyway.
There was a problem hiding this comment.
good point, I'll rework.
astro/src/content/docs/extend/examples/modeling-hierarchies.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| <EnterprisePlanBlurb /> | ||
|
|
||
| In this option, you use [FusionAuth FGA by Permify](/docs/extend/fine-grained-authorization/fusionauth-fga), a standalone authorization server. |
There was a problem hiding this comment.
| In this option, you use [FusionAuth FGA by Permify](/docs/extend/fine-grained-authorization/fusionauth-fga), a standalone authorization server. | |
| This option demonstrates how you can model the same hierarchy using [fine-grained authorization](/docs/extend/fine-grained-authorization/fusionauth-fga) (FGA) with Permify, a standalone authorization server. |
Suggestion: define "FGA" before we use the acronym.
There was a problem hiding this comment.
Happy to define FGA before we use it as an acronym. But the product (Permify supported by FusionAuth) is called "FusionAuth FGA by Permify" and I want to use that name. Will rework.
|
|
||
| To use this solution, you need to run a separate authorization server, either in your environment or in FusionAuth Cloud. | ||
|
|
||
| [Learn more about FusionAuth FGA by Permify](/docs/extend/fine-grained-authorization/fusionauth-fga). |
There was a problem hiding this comment.
| [Learn more about FusionAuth FGA by Permify](/docs/extend/fine-grained-authorization/fusionauth-fga). | |
| For more information, see the [fine-grained authorization documentation](/docs/extend/fine-grained-authorization/fusionauth-fga). |
suggestion: make it more obvious that we're linking to another section of the FA docs, and reduce usage of the terms "FusionAuth" and "Permify", which can get a bit tiring to read since they're company names, not words.
There was a problem hiding this comment.
See above about that being the product name :) .
| --- | ||
| import {RemoteCode} from '@fusionauth/astro-components'; | ||
| import Aside from 'src/components/Aside.astro'; | ||
| import EnterprisePlanBlurb from 'src/content/docs/_shared/_enterprise-plan-blurb.astro'; |
There was a problem hiding this comment.
Why add EnterprisePlanBlurb here if we don't use it on the page?
|
|
||
| ## Licensing Requirements | ||
|
|
||
| Support for FusionAuth FGA by Permify requires an Enterprise plan, as does provisioning FusionAuth FGA by Permify instances in FusionAuth Cloud. |
There was a problem hiding this comment.
Why not use the existing enterprise blurb?
There was a problem hiding this comment.
Hmmm. It's because you can use Permify without an enterprise plan, it is only the support and hosting that require enterprise.
Maybe I can use the blurb here and include a modified version of the text as well.
astro/src/content/json/features.json
Outdated
| "link": "/docs/extend/code/lambdas/mfa-requirement" | ||
| }, | ||
| { | ||
| "displayName": "FGA by Permify Hosting And Support", |
There was a problem hiding this comment.
| "displayName": "FGA by Permify Hosting And Support", | |
| "displayName": "fine-grained authorization (FGA) with Permify", |
Suggestion: define the acronym before we use it; omit 'hosting and support' since we don't specify that for any other features
There was a problem hiding this comment.
well, those are the only parts of Permify we charge for :) .
There was a problem hiding this comment.
Pull request overview
Updates documentation to position FusionAuth FGA by Permify as an Enterprise-supported/hosted option and surfaces it as an alternative approach in the hierarchy modeling guide.
Changes:
- Added “FusionAuth FGA by Permify Hosting and Support” to the Enterprise features list.
- Added a licensing/support section to the FusionAuth FGA by Permify documentation.
- Expanded the “Modeling Hierarchies” guide with an Enterprise-blurb’d FGA alternative and example schema/SDK usage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| astro/src/content/json/features.json | Adds an Enterprise feature entry linking to the FusionAuth FGA by Permify docs. |
| astro/src/content/docs/extend/fine-grained-authorization/fusionauth-fga.mdx | Documents licensing/support expectations for FusionAuth FGA by Permify. |
| astro/src/content/docs/extend/examples/modeling-hierarchies.mdx | Adds an Enterprise FGA alternative section with schema and permission-check example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
astro/src/content/docs/extend/examples/modeling-hierarchies.mdx
Outdated
Show resolved
Hide resolved
astro/src/content/json/features.json
Outdated
| "displayName": "FGA by Permify Hosting And Support", | ||
| "plan": "enterprise", | ||
| "link": "/docs/extend/fine-grained-authorization/fusionauth-fga" |
There was a problem hiding this comment.
In features.json, other displayName entries use sentence case with a lowercase “and” (e.g. “Advanced and Gaming…”, “Entity Management and …”). Consider changing “Hosting And Support” to “Hosting and Support” for consistency.
astro/src/content/docs/extend/examples/modeling-hierarchies.mdx
Outdated
Show resolved
Hide resolved
astro/src/content/docs/extend/examples/modeling-hierarchies.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This does the following: