Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
env: ${{ matrix.env }}
steps:
- name: Repository checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
- name: Setup python
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8

- name: Initialize CodeQL
uses: github/codeql-action/init@51f77329afa6477de8c49fc9c7046c15b9a4e79d
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
if: github.repository == 'systemd/systemd' || github.repository == 'systemd/systemd-stable'

steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
- uses: systemd/mkosi@9e31235211d975bae25622d6205a8396d104335e

# Freeing up disk space with rm -rf can take multiple minutes. Since we don't need the extra free space
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/coverity.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
COVERITY_SCAN_NOTIFICATION_EMAIL: "${{ secrets.COVERITY_SCAN_NOTIFICATION_EMAIL }}"
steps:
- name: Repository checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
# Reuse the setup phase of the unit test script to avoid code duplication
- name: Install build dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/development-freeze.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
name: Pull Request Metadata

- name: Repository checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
with:
fetch-depth: 0

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/differential-shellcheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:

steps:
- name: Repository checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
with:
fetch-depth: 0

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gather-pr-metadata.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

steps:
- name: Repository checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8

- id: metadata
name: Gather Pull Request Metadata
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue-labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
template: [ bug_report.yml, feature_request.yml ]

steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8

- name: Parse issue form
uses: stefanbuck/github-issue-parser@1e5bdee70d4b3e066a33aa0669ab782943825f94
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:

steps:
- name: Repository checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
if: github.event_name == 'pull_request'

- name: Label PR based on policy in labeler.yml
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:

steps:
- name: Repo checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
with:
# We need a full repo clone
fetch-depth: 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mkosi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ jobs:
shim: 0

steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
- uses: systemd/mkosi@9e31235211d975bae25622d6205a8396d104335e

# Freeing up disk space with rm -rf can take multiple minutes. Since we don't need the extra free space
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scorecards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
persist-credentials: false

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests-musl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Repository checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8

- name: Install build dependencies
uses: jirutka/setup-alpine@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
runner: ubuntu-24.04-s390x
steps:
- name: Repository checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
- name: Install build dependencies
run: |
# Drop XDG_* stuff from /etc/environment, so we don't get the user
Expand Down
2 changes: 1 addition & 1 deletion src/analyze/analyze-blame.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ int verb_blame(int argc, char *argv[], void *userdata) {
if (r < 0)
return bus_log_connect_error(r, arg_transport, arg_runtime_scope);

n = acquire_time_data(bus, /* require_finished= */ false, &times);
n = acquire_time_data(bus, /* require_finished = */ false, &times);
if (n <= 0)
return n;

Expand Down
34 changes: 17 additions & 17 deletions src/analyze/analyze-condition.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ static int parse_condition(Unit *u, const char *line) {
assert(u);
assert(line);

line = skip_leading_chars(line, /* bad= */ NULL);
line = skip_leading_chars(line, /* bad = */ NULL);

const char *eq = strchr(line, '=');
if (!eq)
Expand All @@ -27,7 +27,7 @@ static int parse_condition(Unit *u, const char *line) {
if (!type_string)
return log_oom();

delete_trailing_chars(type_string, /* bad= */ NULL);
delete_trailing_chars(type_string, /* bad = */ NULL);

Condition **target;
ConditionType type;
Expand All @@ -41,24 +41,24 @@ static int parse_condition(Unit *u, const char *line) {
if (type < 0)
return log_error_errno(type, "Cannot parse \"%s\".", line);

const char *val = skip_leading_chars(eq + 1, /* bad= */ NULL);
const char *val = skip_leading_chars(eq + 1, /* bad = */ NULL);

ConfigParserCallback callback;
if (condition_takes_path(type))
callback = config_parse_unit_condition_path;
else
callback = config_parse_unit_condition_string;

return callback(/* unit= */ NULL,
/* filename= */ "(cmdline)",
/* line= */ 0,
/* section= */ NULL,
/* section_line= */ 0,
/* lvalue= */ type_string,
/* ltype= */ type,
/* rvalue= */ val,
/* data= */ target,
/* userdata= */ u);
return callback(/* unit = */ NULL,
/* filename = */ "(cmdline)",
/* line = */ 0,
/* section = */ NULL,
/* section_line = */ 0,
/* lvalue = */ type_string,
/* ltype = */ type,
/* rvalue = */ val,
/* data = */ target,
/* userdata = */ u);
}

_printf_(7, 8)
Expand All @@ -72,10 +72,10 @@ static int log_helper(void *userdata, int level, int error, const char *file, in

va_start(ap, format);
r = log_object_internalv(level, error, file, line, func,
/* object_field= */ unit_log_field(u),
/* object= */ u->id,
/* extra_field= */ NULL,
/* extra= */ NULL,
/* object_field = */ unit_log_field(u),
/* object = */ u->id,
/* extra_field = */ NULL,
/* extra = */ NULL,
format, ap);
va_end(ap);

Expand Down
6 changes: 3 additions & 3 deletions src/analyze/analyze-critical-chain.c
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ static int list_dependencies_one(sd_bus *bus, const char *name, unsigned level,

typesafe_qsort(deps, strv_length(deps), list_dependencies_compare);

r = acquire_boot_times(bus, /* require_finished= */ true, &boot);
r = acquire_boot_times(bus, /* require_finished = */ true, &boot);
if (r < 0)
return r;

Expand Down Expand Up @@ -183,7 +183,7 @@ static int list_dependencies(sd_bus *bus, const char *name) {

times = hashmap_get(unit_times_hashmap, id);

r = acquire_boot_times(bus, /* require_finished= */ true, &boot);
r = acquire_boot_times(bus, /* require_finished = */ true, &boot);
if (r < 0)
return r;

Expand All @@ -210,7 +210,7 @@ int verb_critical_chain(int argc, char *argv[], void *userdata) {
if (r < 0)
return bus_log_connect_error(r, arg_transport, arg_runtime_scope);

n = acquire_time_data(bus, /* require_finished= */ true, &times);
n = acquire_time_data(bus, /* require_finished = */ true, &times);
if (n <= 0)
return n;

Expand Down
2 changes: 1 addition & 1 deletion src/analyze/analyze-fdstore.c
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ static int dump_fdstore(sd_bus *bus, const char *arg) {
if (table_isempty(table) && !sd_json_format_enabled(arg_json_format_flags))
log_info("No file descriptors in fdstore of '%s'.", unit);
else {
r = table_print_with_pager(table, arg_json_format_flags, arg_pager_flags, /* show_header= */ true);
r = table_print_with_pager(table, arg_json_format_flags, arg_pager_flags, /* show_header= */true);
if (r < 0)
return r;
}
Expand Down
4 changes: 2 additions & 2 deletions src/analyze/analyze-pcrs.c
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ static int get_current_pcr(const char *alg, uint32_t pcr, void **ret, size_t *re
if (r < 0)
return log_error_errno(r, "Failed to read '%s': %m", p);

r = unhexmem_full(s, ss, /* secure= */ false, &buf, &bufsize);
r = unhexmem_full(s, ss, /* secure = */ false, &buf, &bufsize);
if (r < 0)
return log_error_errno(r, "Failed to decode hex PCR data '%s': %m", s);

Expand Down Expand Up @@ -141,7 +141,7 @@ int verb_pcrs(int argc, char *argv[], void *userdata) {
return r;
}

r = table_print_with_pager(table, arg_json_format_flags, arg_pager_flags, /* show_header= */ true);
r = table_print_with_pager(table, arg_json_format_flags, arg_pager_flags, /* show_header= */true);
if (r < 0)
return r;

Expand Down
4 changes: 2 additions & 2 deletions src/analyze/analyze-plot.c
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ int verb_plot(int argc, char *argv[], void *userdata) {
if (r < 0)
return bus_log_connect_error(r, arg_transport, arg_runtime_scope);

n = acquire_boot_times(bus, /* require_finished= */ true, &boot);
n = acquire_boot_times(bus, /* require_finished = */ true, &boot);
if (n < 0)
return n;

Expand All @@ -497,7 +497,7 @@ int verb_plot(int argc, char *argv[], void *userdata) {
return n;
}

n = acquire_time_data(bus, /* require_finished= */ true, &times);
n = acquire_time_data(bus, /* require_finished = */ true, &times);
if (n <= 0)
return n;

Expand Down
12 changes: 6 additions & 6 deletions src/analyze/analyze-security.c
Original file line number Diff line number Diff line change
Expand Up @@ -1884,7 +1884,7 @@ static int assess(const SecurityInfo *info,
return log_error_errno(r, "Failed to set columns to display: %m");
}

r = table_print_with_pager(details_table, json_format_flags, pager_flags, /* show_header= */ true);
r = table_print_with_pager(details_table, json_format_flags, pager_flags, /* show_header= */true);
if (r < 0)
return r;
}
Expand Down Expand Up @@ -2897,7 +2897,7 @@ static int analyze_security(sd_bus *bus,
fflush(stdout);
}

r = table_print_with_pager(overview_table, json_format_flags, pager_flags, /* show_header= */ true);
r = table_print_with_pager(overview_table, json_format_flags, pager_flags, /* show_header= */true);
if (r < 0)
return r;
}
Expand All @@ -2919,19 +2919,19 @@ int verb_security(int argc, char *argv[], void *userdata) {

unsigned line = 0, column = 0;
if (arg_security_policy) {
r = sd_json_parse_file(/* f= */ NULL, arg_security_policy, /* flags= */ 0, &policy, &line, &column);
r = sd_json_parse_file(/*f=*/ NULL, arg_security_policy, /*flags=*/ 0, &policy, &line, &column);
if (r < 0)
return log_error_errno(r, "Failed to parse '%s' at %u:%u: %m", arg_security_policy, line, column);
} else {
_cleanup_fclose_ FILE *f = NULL;
_cleanup_free_ char *pp = NULL;

r = search_and_fopen_nulstr("systemd-analyze-security.policy", "re", /* root= */ NULL, CONF_PATHS_NULSTR("systemd"), &f, &pp);
r = search_and_fopen_nulstr("systemd-analyze-security.policy", "re", /*root=*/ NULL, CONF_PATHS_NULSTR("systemd"), &f, &pp);
if (r < 0 && r != -ENOENT)
return r;

if (f) {
r = sd_json_parse_file(f, pp, /* flags= */ 0, &policy, &line, &column);
r = sd_json_parse_file(f, pp, /*flags=*/ 0, &policy, &line, &column);
if (r < 0)
return log_error_errno(r, "[%s:%u:%u] Failed to parse JSON policy: %m", pp, line, column);
}
Expand All @@ -2950,5 +2950,5 @@ int verb_security(int argc, char *argv[], void *userdata) {
arg_profile,
arg_json_format_flags,
arg_pager_flags,
/* flags= */ 0);
/*flags=*/ 0);
}
2 changes: 1 addition & 1 deletion src/analyze/analyze-time-data.c
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ int pretty_boot_time(sd_bus *bus, char **ret) {
BootTimes *t;
int r;

r = acquire_boot_times(bus, /* require_finished= */ true, &t);
r = acquire_boot_times(bus, /* require_finished = */ true, &t);
if (r < 0)
return r;

Expand Down
2 changes: 1 addition & 1 deletion src/analyze/analyze-unit-gdb.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ int verb_unit_gdb(int argc, char *argv[], void *userdata) {
} else
assert_not_reached();

r = strv_extend_strv(&debugger_call, arg_debugger_args, /* filter_duplicates= */ false);
r = strv_extend_strv(&debugger_call, arg_debugger_args, /* filter_duplicates = */ false);
if (r < 0)
return log_oom();

Expand Down
2 changes: 1 addition & 1 deletion src/analyze/analyze-verify-util.c
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ static int verify_unit(Unit *u, bool check_man, const char *root) {
unit_dump(u, stdout, "\t");

log_unit_debug(u, "Creating %s/start job", u->id);
r = manager_add_job(u->manager, JOB_START, u, JOB_REPLACE, &error, /* ret= */ NULL);
r = manager_add_job(u->manager, JOB_START, u, JOB_REPLACE, &error, /* ret = */ NULL);
if (r < 0)
log_unit_error_errno(u, r, "Failed to create %s/start: %s", u->id, bus_error_message(&error, r));

Expand Down
Loading
Loading