Skip to content

Enable processing for all abstracts. #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EliteMasterEric wants to merge 7 commits into
base: experimental
Choose a base branch
from
Open

Enable processing for all abstracts. #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b55a91c
Enable processing for all abstracts.
EliteMasterEric Jan 27, 2026
deac45e
fix compile errors
lemz1 Jan 30, 2026
0472b9a
Gracefully fail (and display a script error) rather than throwing an …
EliteMasterEric Jan 31, 2026
fae8680
break out from loops after finding getter/setter
NotHyper-474 Feb 1, 2026
8903100
Remove some extra print calls.
EliteMasterEric Feb 2, 2026
88253e2
Properly support enum abstract values (i.e. inline get-only static fi…
EliteMasterEric Feb 2, 2026
68d46b7
Add timing data for processing abstracts to the compilation output.
EliteMasterEric Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions polymod/hscript/_internal/PolymodInterpEx.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ class PolymodInterpEx extends Interp
continue;
}

Polymod.error(SCRIPT_CLASS_MODULE_NOT_FOUND, 'Could not import ${imp.fullPath}', clsPath);
Polymod.error(SCRIPT_CLASS_MODULE_NOT_FOUND, 'Could not import ${imp.fullPath}. Check to ensure the module exists and is spelled correctly.', clsPath);
}

// Check if the scripted classes extend the right type.
Expand All @@ -338,15 +338,15 @@ class PolymodInterpEx extends Interp
case CTPath(path, params):
if (params != null && params.length > 0)
{
Polymod.error(SCRIPT_CLASS_MODULE_NOT_FOUND, 'Could not extend ${superClassPath}, do not include type parameters in super class name', clsPath);
Polymod.error(SCRIPT_CLASS_MODULE_NOT_FOUND, 'Could not extend ${superClassPath}, do not include type parameters in super class name.', clsPath);
}

default:
// Other error handling?
}

// Default
Polymod.error(SCRIPT_CLASS_MODULE_NOT_FOUND, 'Could not extend ${superClassPath}, is the type imported?', clsPath);
Polymod.error(SCRIPT_CLASS_MODULE_NOT_FOUND, 'Could not extend ${superClassPath}. Make sure the type to extend has been imported.', clsPath);
}
else
{
Expand Down Expand Up @@ -1852,8 +1852,14 @@ class PolymodInterpEx extends Interp
} else if (PolymodScriptClass.abstractClassImpls.exists(importedClass.fullPath)) {
// We used a macro to map each abstract to its implementation.
importedClass.cls = PolymodScriptClass.abstractClassImpls.get(importedClass.fullPath);
trace('RESOLVED ABSTRACT CLASS ${importedClass.fullPath} -> ${Type.getClassName(importedClass.cls)}');
trace(Type.getClassFields(importedClass.cls));

if (importedClass.cls == null) {
Polymod.warning(SCRIPT_CLASS_MODULE_NOT_FOUND, 'Abstract type ${importedClass.fullPath} could not be resolved. Try using the underlying type instead.', origin);
} else {
// trace('RESOLVED ABSTRACT CLASS ${importedClass.fullPath} -> ${Type.getClassName(importedClass.cls)}');
// trace(Type.getClassFields(importedClass.cls));
}

} else if (_scriptEnumDescriptors.exists(importedClass.fullPath)) {
// do nothing
} else {
Expand All @@ -1866,7 +1872,6 @@ class PolymodInterpEx extends Interp

// If the class is still not found, skip this import entirely.
if (resultCls == null && resultEnm == null) {
//Polymod.error(SCRIPT_CLASS_MODULE_NOT_FOUND, 'Could not import class ${importedClass.fullPath}', origin);
// this could be a scripted class or enum that hasn't been registered yet
importsToValidate.set(importedClass.name, importedClass);
continue;
Expand Down Expand Up @@ -1908,16 +1913,13 @@ class PolymodInterpEx extends Interp
} else if (PolymodScriptClass.abstractClassImpls.exists(importedClass.fullPath)) {
// We used a macro to map each abstract to its implementation.
importedClass.cls = PolymodScriptClass.abstractClassImpls.get(importedClass.fullPath);
trace('RESOLVED ABSTRACT CLASS ${importedClass.fullPath} -> ${Type.getClassName(importedClass.cls)}');
trace(Type.getClassFields(importedClass.cls));
} else if (_scriptEnumDescriptors.exists(importedClass.fullPath)) {
// do nothing
} else {
var resultCls:Class<Dynamic> = Type.resolveClass(importedClass.fullPath);

// If the class is still not found, skip this import entirely.
if (resultCls == null) {
//Polymod.error(SCRIPT_CLASS_MODULE_NOT_FOUND, 'Could not import class ${importedClass.fullPath}', origin);
// this could be a scripted class that hasn't been registered yet
importsToValidate.set(importedClass.name, importedClass);
continue;
Expand Down
Loading