Fixes for HashLink #258
Open
Fixes for HashLink #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotHyper-474
force-pushed
the
hashlink-fixes
branch
from
5c37370 to
dbb1840
Compare
Author
|
Hmm I just realized that in hxcpp if you try to get a value from a enum that doesn't exist it'll just return null, meanwhile my last commit made it so that in HashLink it throws an error. Maybe it should be reverted. |
Member
|
Is this fully functional or still in testing? |
Author
|
I guess it stills needs better parity with HXCPP (which I don't think will ever be 100% achievable) |
NotHyper-474
force-pushed
the
hashlink-fixes
branch
2 times, most recently
from
d7c5963 to
d05358a
Compare
NotHyper-474
force-pushed
the
hashlink-fixes
branch
2 times, most recently
from
8638713 to
eaaacd1
Compare
NotHyper-474
force-pushed
the
hashlink-fixes
branch
from
eaaacd1 to
38ba0e4
Compare
NotHyper-474
force-pushed
the
hashlink-fixes
branch
4 times, most recently
from
93a2de6 to
8318d9b
Compare
NotHyper-474
force-pushed
the
hashlink-fixes
branch
from
8318d9b to
43657d8
Compare
NotHyper-474
force-pushed
the
hashlink-fixes
branch
from
43657d8 to
0a7283c
Compare
NotHyper-474
force-pushed
the
hashlink-fixes
branch
3 times, most recently
from
7ebf32b to
6a46310
Compare
NotHyper-474
force-pushed
the
hashlink-fixes
branch
7 times, most recently
from
8521083 to
9c1ba6a
Compare
NotHyper-474
force-pushed
the
hashlink-fixes
branch
from
9c1ba6a to
a19bff2
Compare
Author
|
I think this is good enough to at least be able to run FNF in HashLink. I don't think there's a way to fix all of the parity issues, so don't expect cross-target compatibility of mods to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues with HashLink: an error when trying to resolve abstracts, and a workaround for HaxeFoundation/hscript#96 by using a macro that creates a wrapper class for
StdandMath.Edit: Now also fixes enum values not being evaluated properly