Feature/adding matching lights path tracer and rasterizer#87
Open
juanchuletas wants to merge 4 commits intomainfrom
Open
Feature/adding matching lights path tracer and rasterizer#87juanchuletas wants to merge 4 commits intomainfrom
juanchuletas wants to merge 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a first-class light data model, viewport light gizmos, and a physically based multi-light rasterizer pipeline. Replaces the hardcoded single Phong light in SceneManager with a proper light list shared across the editor, gizmo renderer, and rasterizer.
Type of Change
Changes Made
Technical Details
Billboard gizmo extracts camera right and up vectors directly from view matrix columns. Gizmo sphere is three great circles generated procedurally at init, uploaded as a static VAO, positioned via lightWorldPos uniform at render time. Rasterizer attenuation changed from the Ogre3D polynomial approximation to true inverse square 1/(d^2 + 1e-6) matching the path tracer scale so both renderers respond consistently to the same power value.
Testing
Performance Impact
No measurable impact on rasterizer path. Gizmo render adds one draw call per light.
Notes for Reviewers
Path tracer light wiring via Space::loadLightsFromScene and Area light geometry generation are intentionally out of scope and tracked separately. The core_renderer.hpp directional light branch is included as a kernel-side prerequisite for the next PR.