feat(feature option): new feature option to navigate to Labs or Catalog page #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…og page for platform feature Added a new feature option 'entrypoint' which enables a user to choose which page they want to land on . Currently, they can choose 'labs' or 'catalog' for this option which navigates them to Labs page or Catalog page. This option is available when they use 'platform' feature.
pipopotamasu
changed the title
brandonbay
approved these changes
Mar 18, 2025
| featureType: FeatureType, | ||
| featureOptions: FeatureOptions<FeatureType> | ||
| ) => { | ||
| if ("entrypoint" in featureOptions) { |
There was a problem hiding this comment.
Is this if necessary to confirm the type to tsc?
Collaborator
Author
There was a problem hiding this comment.
This is not for tsc.
We would like to remove entrypoint point option when it is given. That's why I put this if condition. Technically, we can merge this if with the following one but I wanted to make it separated for readability
|
Looks good to me! |
Collaborator
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new feature option 'entrypoint' which enables a user to choose which page they want to land on . Currently, they can choose 'labs' or 'catalog' for this option which navigates them to Labs page or Catalog page. This option is available when they use 'platform' feature.