Fix file browser volume mount directory#97
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the file browser volume mount configuration where an incorrect volume name was being referenced.
Key Changes
- Corrected the volume mount name in the file browser container from
'vn-homevn-agent'to'vn-homevn-fulling'to match the actual volumeClaimTemplate name - Added "homevn" to the VS Code spell checker dictionary to recognize this naming convention
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/k8s/sandbox-manager.ts | Fixed the file browser container's volume mount reference to use the correct volume name 'vn-homevn-fulling' that matches the volumeClaimTemplate definition |
| .vscode/settings.json | Added "homevn" to the spell checker dictionary to recognize the volume naming convention used in the codebase |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ PR Check Results: PassedBuild Checks
✨ Great work!All checks passed successfully. Your PR is ready for review. Details:
🔗 View Details: |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -125,7 +125,7 @@ export async function uploadFileToFileBrowser( | |||
| .join('/') | |||
|
|
|||
| // Build TUS endpoint with path | |||
There was a problem hiding this comment.
The change from override=false to override=true modifies the file upload behavior significantly. This means files with the same name will now be overwritten without warning. Please add a comment explaining why this change was necessary, as it could lead to accidental data loss if users are not aware that uploads will overwrite existing files.
| // Build TUS endpoint with path | |
| // Build TUS endpoint with path | |
| // NOTE: Changed from override=false to override=true. | |
| // This means files with the same name will now be overwritten without warning. | |
| // Please ensure users are aware of this behavior, as it could lead to accidental data loss. | |
| // The change was necessary to allow uploads to replace existing files when required. |
Uh oh!
There was an error while loading. Please reload this page.