Skip to content

fix: avoid showing GitHub app install modal while repos are loading#141

Merged
Che-Zhu merged 1 commit intomainfrom
codex/projects-import-button-investigation
Mar 9, 2026
Merged

fix: avoid showing GitHub app install modal while repos are loading#141
Che-Zhu merged 1 commit intomainfrom
codex/projects-import-button-investigation

Conversation

@Che-Zhu
Copy link
Copy Markdown
Collaborator

@Che-Zhu Che-Zhu commented Mar 9, 2026

Summary

  • add an explicit loading step to the Import GitHub dialog
  • show Import from GitHub with loading state while checking installation and fetching repos
  • only show Install GitHub App when installation is actually missing

Why

Users with existing GitHub installation were briefly shown the install modal before repos loaded, which looked like a bug.

Validation

  • Type check: pnpm exec tsc --noEmit --pretty false
  • Manual flow expectation: opening Import now shows loading first, then repo list when installation exists

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026

✅ PR Check Results: Passed

Build Checks

Check Status
Lint & Build ✅ Passed
Docker Build ✅ Passed

✨ Great work!

All checks passed successfully. Your PR is ready for review.

Details:

  • ✅ Code quality verified (linting passed)
  • ✅ Build successful
  • ✅ Docker image build verified (linux/amd64)
    Commit: 0822db2ee4a845629be220854cc71c4cd5fdc531
    Branch: codex/projects-import-button-investigation

🔗 View Details:

@Che-Zhu Che-Zhu merged commit 3ff1a32 into main Mar 9, 2026
9 checks passed
@Che-Zhu Che-Zhu deleted the codex/projects-import-button-investigation branch March 9, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant