fix(dockerfile): disable shadcn add --all to avoid React 19 type conflict#125
Merged
fix(dockerfile): disable shadcn add --all to avoid React 19 type conflict#125
Conversation
- Define VS Code-inspired dark theme color system - Document two-section sidebar architecture - Specify component standards (Button, Card, Tabs) - Include typography, border radius, and shadow systems - Reference related files (globals.css, style.md)
…iable
- Add NEXT_VERSION=15.5.9 environment variable for centralized version control
- Update global npm install to use create-next-app@${NEXT_VERSION}
- Update npx command to use create-next-app@${NEXT_VERSION}
This ensures version consistency and makes future upgrades easier by
requiring changes in only one place.
…lict The react-resizable-panels package (dependency of shadcn resizable component) has type incompatibility with React 19. Disable pre-installing all components and allow on-demand installation instead. Addresses: shadcn-ui/ui#9200
✅ PR Check Results: PassedBuild Checks
✨ Great work!All checks passed successfully. Your PR is ready for review. Details:
🔗 View Details: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical build failure in user-created applications.
Related Issue
Problem
When pre-installing all shadcn/ui components via
shadcn add --all, theresizablecomponent pulls inreact-resizable-panels@4.3.2, which has TypeScript type definitions incompatible with React 19.Impact: Users cannot run
pnpm run buildsuccessfully. The build always fails with:Users must manually upgrade
react-resizable-panelsbefore they can build, which is a poor out-of-box experience.Solution
Stop pre-installing shadcn/ui components in the sandbox runtime. Users can add components on-demand:
This avoids shipping broken dependencies and gives users a working
pnpm run buildout of the box.