Skip to content

Conversation

@ohtake
Copy link
Member

@ohtake ohtake commented Jan 16, 2018

As landing pages are static, GH Pages can host them.

  • Pros
    • Reduces traffic and loads on AWS
  • Cons
    • Causes downtime while applying changes
    • Cannot host code coverage report, esdoc and storybook-static

Tasks:

  • Test if custom domain of GitHub Pages works as expected
    • Set custom domain test.cattaz.io to GitHub Pages
    • (@kodakat) Make test.cattaz.io be a CNAME record to FujitsuLaboratories.github.io.
    • (@kodakat) Remove test.cattaz.io record
  • (@kodakat) Make demo.cattaz.io be a CNAME record to the AWS ELB
    • This change does not have side effects
  • Set custom domain cattaz.io to GitHub Pages
    • This change may cause an warning every time you push to gh-pages branch
  • (@kodakat) Set @.cattaz.io to be a CNAME record to FujitsuLaboratories.github.io.
    • This change may cause outages of demo site for a while
  • If you want to release, push to gh-pages instead of release branch

@codecov-io
Copy link

codecov-io commented Jan 16, 2018

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   74.69%   74.69%           
=======================================
  Files          20       20           
  Lines         996      996           
  Branches      115      115           
=======================================
  Hits          744      744           
  Misses        216      216           
  Partials       36       36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165c072...48b42dc. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.564% when pulling 48b42dc on landingpage-gh into 165c072 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants