Pagination and search in student list in admin portal #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement pagination for GetAllCompanies endpoint * Implement pagination and search functionality in GetAllStudents endpoint
* implement pagination for GetAllCompanies endpoint * Added error handling for pagination * Implement pagination and search functionality in GetAllStudents endpoint * Add search functionality to GetAllStudents endpoint with roll number support
shalearkane
reviewed
Apr 7, 2025
| search := ctx.Query("search") | ||
|
|
||
| currentPageStr := ctx.DefaultQuery("page", "0") | ||
| studentsPerPageStr := ctx.DefaultQuery("limit", "0") |
Contributor
Author
There was a problem hiding this comment.
It would be better if the value 50 is handled in the frontend, if some issue is there from the frontend in sending the params, then it defaults to 0 and returns all the students.
| currentPage := 0 | ||
|
|
||
| companies, err := controller.GetAllCompanies(h.MongikClient, noCache) | ||
| currentPage, err := strconv.Atoi(ctx.Request.URL.Query().Get("page")) |
Contributor
Author
There was a problem hiding this comment.
Will refactor the companies pagination in another pr. Currently it works as expected.
… and extract roll number bounds into a separate utility function
…used rollNoBounds utility file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.