2 include gtest #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t via GOETHE_BUILD_TESTS; ignore generated test artifacts
…st/CTest), and install usage
…dev package requirement for system SDL3
- Modified test YAML to include unclosed quoted string - Ensures YAML is syntactically invalid and triggers yaml-cpp exception - All 14 tests now pass successfully
- Add comprehensive CI/CD workflows for testing and building - Restructure source code into src/engine/core/ with modular design - Add compression system with multiple backend implementations - Add statistics system for performance monitoring - Add dialog system with YAML parsing and validation - Add build scripts and development tools - Add documentation in docs/ directory - Add proper header organization in include/goethe/ - Add linting and formatting configuration - Remove old sample code and outdated files - Update CMakeLists.txt for new structure
- Remove tests/CMakeLists.txt and tests/test_engine_basic.cpp - These files were from an older version of the project - Current tests are properly located in src/tests/ with new architecture
- Replace deprecated actions/upload-artifact@v3 with v4 - Fixes deprecation warning and ensures future compatibility - Updated in all workflow files: - compression-test.yml - cpp-tests.yml - full-test-suite.yml - statistics-test.yml
- Update project summary with statistics system and enhanced testing - Enhance README with new features and improved examples - Update quick start guide with current dependencies and tools - Expand architecture documentation with statistics and testing - Add comprehensive coverage of new features: - Statistics tracking system - Google Test integration - Command-line analysis tools - Advanced dialog features (conditions, effects, voice, portraits) - Dual YAML format support - Update installation instructions for all platforms - Add development tools and troubleshooting sections
toymak3r
force-pushed
the
2-include-gtest
branch
from
1135d19 to
5bc9335
Compare
- Fix CI/CD build failures by using CMAKE_CURRENT_SOURCE_DIR - Ensure test files are found correctly in all build environments - Update paths for all test executables and tools
- Remove unsupported clang-format option that was causing CI/CD failures - Fix clang-format configuration to be compatible with current versions - Ensure code formatting checks pass in CI/CD pipeline
- Add pkg-config fallback for yaml-cpp detection on macOS - Handle both find_package and pkg-config yaml-cpp installations - Fix CI/CD build failures on macOS due to missing yaml-cpp - Improve dependency detection robustness across platforms
- Fix array comment alignment in factory.cpp - Fix inline function formatting in null.hpp and zstd.hpp - Fix function call formatting in zstd.cpp - Fix spacing and indentation in all compression files - Ensure consistent code formatting according to .clang-format rules - Fix all clang-format violations reported by CI/CD pipeline
- Add scripts/pre-commit-verify.sh for basic verification before commits - Add scripts/pre-push-verify.sh for comprehensive verification before pushes - Add scripts/install-hooks.sh for easy hook installation - Verification includes: - Code formatting checks (clang-format) - Build tests (Debug and Release) - All unit tests (dialog, compression, statistics) - CTest integration - TODO/FIXME comment detection - GitHub Actions workflow validation - Deprecated action detection - Merge conflict detection - Hardcoded path detection - Documentation checks - Sensitive information detection These scripts ensure that local changes will pass GitHub Actions tests
- Add buil/ to .gitignore to prevent build artifacts from being tracked - This prevents the pre-push verification from detecting uncommitted build files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the purpose of this pull request.
Testing
Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
cmake -S . -B buildcmake --build buildctest --test-dir buildChecklist