Skip to content

Using attribute routing when generating AdminControllers#18

Merged
mamazu merged 1 commit intomasterfrom
attribute_routing
May 2, 2025
Merged

Using attribute routing when generating AdminControllers#18
mamazu merged 1 commit intomasterfrom
attribute_routing

Conversation

@mamazu
Copy link
Collaborator

@mamazu mamazu commented Mar 10, 2025

What's inside

  • Fixing generated code
    • it was using variables that were never set
    • Not properly return a 404 when no entity was found
    • Fixing errors phpstan found when running over the generated code
  • Removing documentation about "public static" properties being supported. This would make the code more complicated. Sulu only uses constants so we should be fine to enforce this here.
  • Only show the "add yaml to your application" for the first time and then autoconfiguring works for the rest of the time.

@mamazu mamazu changed the title Using attribute routing Using attribute routing when generating Controllers Mar 10, 2025
@mamazu mamazu changed the title Using attribute routing when generating Controllers Using attribute routing when generating AdminControllers Mar 10, 2025
@mamazu mamazu force-pushed the attribute_routing branch from c22e6d7 to 72072a9 Compare March 10, 2025 15:16
@mamazu mamazu force-pushed the attribute_routing branch from 72072a9 to 1a83690 Compare March 16, 2025 11:57
@mamazu mamazu merged commit c71be0d into master May 2, 2025
2 checks passed
@mamazu mamazu deleted the attribute_routing branch May 2, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants