Skip to content

feat: changed MailFinderService to load all TemplateTypes at once#86

Merged
tinect merged 6 commits intomainfrom
feat/loadTemplateTypeAtOnce
Jan 21, 2026
Merged

feat: changed MailFinderService to load all TemplateTypes at once#86
tinect merged 6 commits intomainfrom
feat/loadTemplateTypeAtOnce

Conversation

@tinect
Copy link
Copy Markdown
Member

@tinect tinect commented Dec 23, 2025

⚠️BREAKING CHANGE for MailFinderServiceInterface ⚠️

@tinect
Copy link
Copy Markdown
Member Author

tinect commented Dec 23, 2025

@shyim @Schrank something like this I was thinking of.

Preventing the user from being able to edit the template could be really hard, while we support shopware 6.5 - 6.7 in one version - and you know the challenge regarding fields in admin xD

@tinect tinect force-pushed the feat/loadTemplateTypeAtOnce branch 5 times, most recently from 5716d67 to 93c6866 Compare December 23, 2025 22:42
@tinect tinect marked this pull request as ready for review December 23, 2025 23:22
@tinect tinect force-pushed the feat/loadTemplateTypeAtOnce branch 4 times, most recently from 9231d15 to 55db7e5 Compare December 23, 2025 23:50
@tinect tinect requested a review from shyim December 24, 2025 13:00
@tinect tinect force-pushed the feat/loadTemplateTypeAtOnce branch from 55db7e5 to 395ee71 Compare December 24, 2025 13:14
@tinect tinect force-pushed the feat/loadTemplateTypeAtOnce branch from 395ee71 to 6ee9afa Compare December 24, 2025 13:49
@tinect
Copy link
Copy Markdown
Member Author

tinect commented Dec 24, 2025

@Schrank would this work for you?

@Schrank
Copy link
Copy Markdown

Schrank commented Jan 12, 2026

My colleague tested it and it works as expected <3 Feel free to merge it!

@Schrank
Copy link
Copy Markdown

Schrank commented Jan 12, 2026

And thank you very much for the work <3

@tinect
Copy link
Copy Markdown
Member Author

tinect commented Jan 19, 2026

@shyim ? :-)

BREAKING CHANGE: MailFinderServiceInterface has changed structure
@schneider-felix
Copy link
Copy Markdown
Member

Well no you'll also need to add the use-Statement for Entity :D

Co-authored-by: Felix Schneider <69912882+schneider-felix@users.noreply.github.com>
@tinect tinect force-pushed the feat/loadTemplateTypeAtOnce branch from 9cedd5d to f611089 Compare January 19, 2026 15:51
@tinect tinect force-pushed the feat/loadTemplateTypeAtOnce branch from 6cebe8d to d7db087 Compare January 21, 2026 07:03
@tinect tinect merged commit 05394ba into main Jan 21, 2026
6 checks passed
@tinect tinect deleted the feat/loadTemplateTypeAtOnce branch January 21, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants