Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,16 @@ jobs:
fail-fast: false
matrix:
php-version:
- '7.4'
- '8.0'
- '8.1'
- '8.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also keep a job on PHP 8.1 with unmodified dependencies.

- '8.3'
- '8.4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you are adding new PHP versions, you can add 8.5 as well.

symfony-version:
- '4.4.*'
- '5.4.*'
- '6.4.*'
exclude:
- php-version: '7.4'
symfony-version: '6.4.*'
- php-version: '8.0'
symfony-version: '6.4.*'
- 'none'
include:
- php-version: '8.2'
symfony-version: '7.0.*'
- php-version: '8.1'
symfony-version: '5.4.*'
- php-version: '8.1'
symfony-version: '6.4.*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add an explicit job for Symfony 7.4, as it is also a LTS version.

steps:
- name: Checkout
uses: actions/checkout@v6
Expand All @@ -45,7 +40,8 @@ jobs:
run: composer validate --no-check-lock

- name: Configure Symfony version
run: composer require --no-update "symfony/config:${{ matrix.symfony-version }}" "symfony/dependency-injection:${{ matrix.symfony-version }}"
run: composer require --no-update "symfony/config:${{ matrix.symfony-version }}" "symfony/dependency-injection:${{ matrix.symfony-version }}" "symfony/event-dispatcher:${{ matrix.symfony-version }}"
if: matrix.symfony-version != 'none'

- name: Install dependencies
run: composer install --prefer-dist --no-progress
Expand Down
12 changes: 7 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,18 @@
],
"homepage": "https://github.com/FriendsOfBehat/MinkExtension#readme",
"require": {
"php": "^7.4 || ^8",
"php": "^8.1",
"behat/behat": "^3.0.5",
"behat/mink": "^1.5",
"symfony/config": "^4.4 || ^5.0 || ^6.0 || ^7.0",
"symfony/deprecation-contracts": "^1.0 || ^2.0 || ^3.0"
"symfony/config": "^5.4 || ^6.4 || ^7.3",
"symfony/dependency-injection": "^5.4 || ^6.4 || ^7.3",
"symfony/deprecation-contracts": "^1.0 || ^2.0 || ^3.0",
"symfony/event-dispatcher": "^5.4 || ^6.4 || ^7.3"
},
"require-dev": {
"behat/mink-goutte-driver": "^1.1 || ^2.0",
"phpspec/phpspec": "^6.0 || ^7.0 || 7.1.x-dev",
"mink/webdriver-classic-driver": "^1.0@dev"
"phpspec/phpspec": "^7.0 || ^8.0",
"mink/webdriver-classic-driver": "^1.0"
},
"replace": {
"behat/mink-extension": "self.version"
Expand Down