feat : implement vsids overflow management

[FreeYourSoul]

Summary by CodeRabbit

• New Features

  • Added several CNF (Conjunctive Normal Form) files for SAT solver testing, including examples for simple formulas, propagation chains, conflicts, and the 4-queen problem.
  • Introduced documentation describing the purpose and structure of each CNF test file, along with example outputs for the 4-queen problem.

• Documentation

  • Added a README explaining the included CNF files and their use cases.

• Refactor

  • Improved the SAT solver's variable activity management with normalization and decay to enhance stability and performance.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Several new CNF files were introduced to document and test various SAT solver behaviors, including simple cases, propagation chains, conflicts, and the 4-queen problem. A README was added to describe these files. In the SAT solver backend, the VSIDS activity update logic was refactored and extended to include normalization and decay.

Changes

File(s)	Change Summary
docs/cnf/4-queen-problem.cnf	Added CNF encoding of the 4-queen problem with 16 variables and 81 clauses.
docs/cnf/README.md	Added documentation describing all included CNF test files and their intended SAT solver behaviors.
docs/cnf/propagation-chain.cnf	Added CNF file encoding a variable propagation chain using 4 variables and 4 clauses.
docs/cnf/simple_conflict.cnf, docs/cnf/test.cnf	Added CNF files encoding simple conflict patterns for SAT solver testing, each with 4 variables and 4 clauses.
docs/cnf/simple_straight.cnf	Added a basic CNF file with 3 variables and 2 clauses for straightforward SAT solver validation.
fabko/compiler/backend/sat/solver_context.cpp	Refactored and extended VSIDS activity update: renamed function, added normalization, periodic decay, and updated call site logic.

Sequence Diagram(s)

sequenceDiagram
    participant SolverLoop
    participant SolverContext
    participant Clause

    SolverLoop->>SolverContext: update_vsids_activity(learned_clause)
    alt Activity near max value
        SolverContext->>SolverContext: Normalize all activities
    end
    SolverContext->>SolverContext: Increase activity for vars in learned_clause
    alt Conflict count reached decay interval
        SolverContext->>SolverContext: Decay all activities
    end

Loading

Poem

In the warren of logic, new puzzles appear,
Queens on a board, and conflicts to clear.
With VSIDS now wiser, decay and normalize,
SAT solver hops forward, with keen rabbit eyes.
CNFs for testing, a README for lore—
Hooray for new logic to ponder and explore!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4d669f and eec0963.

📒 Files selected for processing (7)

• docs/cnf/4-queen-problem.cnf (1 hunks)
• docs/cnf/README.md (1 hunks)
• docs/cnf/propagation-chain.cnf (1 hunks)
• docs/cnf/simple_conflict.cnf (1 hunks)
• docs/cnf/simple_straight.cnf (1 hunks)
• docs/cnf/test.cnf (1 hunks)
• fabko/compiler/backend/sat/solver_context.cpp (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.