[1.0.0] Migate all unit tests from PHPSpec to PHPUnit #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChadSikorra
force-pushed
the
v1-migrate-tests-to-phpunit
branch
2 times, most recently
from
cd41e28 to
d26b40a
Compare
ChadSikorra
force-pushed
the
v1-migrate-tests-to-phpunit
branch
from
d26b40a to
08f956c
Compare
…overed via static analysis.
…rading it as part of the move to phpunit. I will revisit and fix the necessary items at level 10 before bumping it.
ChadSikorra
force-pushed
the
v1-migrate-tests-to-phpunit
branch
2 times, most recently
from
3f22270 to
156db26
Compare
ChadSikorra
force-pushed
the
v1-migrate-tests-to-phpunit
branch
from
156db26 to
63085f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is long overdue, but it's a huge amount of tedious work. This gets the library off of PHPSpec and onto PHPUnit. PHPUnit is basically the standard, has less issues with dependencies, works in a less magical way, and is better supported by static analysis tools.
This PR is a work-in-progress as I couldn't find an automated way to do this. But there isn't much more left to go.