fix: clear setInterval in LoadingComponent on destroy#387
Closed
wowitsjack wants to merge 1 commit intoFredolx:mainfrom
Closed
fix: clear setInterval in LoadingComponent on destroy#387wowitsjack wants to merge 1 commit intoFredolx:mainfrom
wowitsjack wants to merge 1 commit intoFredolx:mainfrom
Conversation
|
|
The loading component's setInterval was never cleared, causing leaked intervals on every create/destroy cycle. Store the interval ID and clear it in ngOnDestroy.
wowitsjack
force-pushed
the
fix/loading-interval-leak
branch
from
bce1b43 to
90cf3ca
Compare
Author
|
Yep, agreed |
wowitsjack
force-pushed
the
fix/loading-interval-leak
branch
2 times, most recently
from
1e4a7d6 to
90cf3ca
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoadingComponent'ssetIntervalwas never cleared, leaking intervals on every create/destroy cyclengOnDestroyOnDestroyinterfaceTest plan