Skip to content

Conversation

@Ugarz
Copy link
Collaborator

@Ugarz Ugarz commented Oct 23, 2025

Hello 👋🏻

I had some time ahead of me so I tried to update the project dependencies (eslint configuration) and fix somes little things. The main goal was to reduce the risk surface because of vulnerabilites found with npm audit, use a new version of Eslint v9.

Changelog

  • Remove Lodash from project dependencies (only 1 function used in App.vue), IsEqual is now replaced by JSON.stringify().
  • Update yarn run lint command to match Eslint new check
  • Bump node from v18.19.1 to v22.18.0 because of the drop for old node versions.
  • Bump Eslint v9.38.0 - documentation
  • Bump vite-ssg from v0.22.2 to v28.2.2 (yeah it's high, but fixes high risks found in npm audit).
  • Bump vue from v3.2.47 to v3.5.2 (vite-ssg needs).
  • Bump @vue/eslint-config-prettier from v^7.1.0 to v10.2.0

I added some comments on the PR below 👇🏻

@Ugarz Ugarz requested review from agateblue and trpyn October 23, 2025 16:36
@Ugarz Ugarz self-assigned this Oct 23, 2025
situation: store.situation
}
if (!isEqual(data, getDefaultState())) {
if (JSON.stringify(data) !== JSON.stringify(getDefaultState())) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I removed a dependency from isEqual if (!isEqual(data, getDefaultState())) {..}

if: github.ref == 'refs/heads/main'
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some warnings on GITHUB_TOKEN and according to the JamesIves/github-pages-deploy-action@v4doc I think it is token which is expected.

@Ugarz Ugarz added the Type : Amélioration Amélioration ou nouvelle fonctionnalité label Oct 24, 2025
@Ugarz Ugarz linked an issue Oct 24, 2025 that may be closed by this pull request
Comment on lines +168 to +174
<button
class="my-2 inverted"
@click.prevent="
deleteData();
formKey++;
"
>
Copy link
Collaborator Author

@Ugarz Ugarz Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here there is a little issue with the Prettierrc configuration:

{
  "$schema": "https://json.schemastore.org/prettierrc",
  "semi": false,
  "tabWidth": 2,
  "singleQuote": true,
  "printWidth": 100,
  "trailingComma": "none"
}

When I run yarn format with "semi": false, it removes the semi-colons ; from here and ends up with an error like:

3:56:04 PM [vite] Internal server error: Error parsing JavaScript expression: Unexpected token, expected "," (3:14)
  Plugin: vite:vue
  File: /home/me/dev/administrans/src/components/DocumentForm.vue:170:29
  169 |              class="my-2 inverted"
  170 |              @click.prevent="
  171 |                deleteData()
      |  ^
  172 |                formKey++
  173 |              "

My skills in Vue.js are not very sharp but maybe we can simplify deleteData()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type : Amélioration Amélioration ou nouvelle fonctionnalité

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eslint misconfiguration

2 participants