-
Notifications
You must be signed in to change notification settings - Fork 7
Eslint v9 setup upgrade + fixes #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| situation: store.situation | ||
| } | ||
| if (!isEqual(data, getDefaultState())) { | ||
| if (JSON.stringify(data) !== JSON.stringify(getDefaultState())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I removed a dependency from isEqual if (!isEqual(data, getDefaultState())) {..}
| if: github.ref == 'refs/heads/main' | ||
| with: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some warnings on GITHUB_TOKEN and according to the JamesIves/github-pages-deploy-action@v4doc I think it is token which is expected.
| <button | ||
| class="my-2 inverted" | ||
| @click.prevent=" | ||
| deleteData(); | ||
| formKey++; | ||
| " | ||
| > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here there is a little issue with the Prettierrc configuration:
{
"$schema": "https://json.schemastore.org/prettierrc",
"semi": false,
"tabWidth": 2,
"singleQuote": true,
"printWidth": 100,
"trailingComma": "none"
}When I run yarn format with "semi": false, it removes the semi-colons ; from here and ends up with an error like:
3:56:04 PM [vite] Internal server error: Error parsing JavaScript expression: Unexpected token, expected "," (3:14)
Plugin: vite:vue
File: /home/me/dev/administrans/src/components/DocumentForm.vue:170:29
169 | class="my-2 inverted"
170 | @click.prevent="
171 | deleteData()
| ^
172 | formKey++
173 | "
My skills in Vue.js are not very sharp but maybe we can simplify deleteData()
Hello 👋🏻
I had some time ahead of me so I tried to update the project dependencies (eslint configuration) and fix somes little things. The main goal was to reduce the risk surface because of vulnerabilites found with
npm audit, use a new version of Eslint v9.Changelog
IsEqualis now replaced byJSON.stringify().yarn run lintcommand to match Eslint new checkv18.19.1tov22.18.0because of the drop for old node versions.v9.38.0- documentationvite-ssgfromv0.22.2tov28.2.2(yeah it's high, but fixes high risks found in npm audit).vuefromv3.2.47tov3.5.2(vite-ssg needs).@vue/eslint-config-prettierfromv^7.1.0tov10.2.0I added some comments on the PR below 👇🏻