ES8 #31
Closed
ES8 #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I made a PR based off of this, rebased off of tests seemed to pass locally, and I'll testing it off of a massdriver PR to see if it still works that way. feel free to set this PR to that branch's commits if it all looks good, or if you want to rebase this yourself, just giving myself some room to test the changes for SRCH-467 👍 |
Contributor
Author
|
@williamge feel free to take ownership of this branch/PR and close it, extend it, copy it, whatever works best for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support elastic search 8 while still using
elastix.Note that updating documents is supported via
PUT /<target>/_doc/<_id>and so updates that use scripts are not supported. Note also that massdriver doesn't useExlasticSearch.Repo.update/4.