do not merge - v1.7.9 diff #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid table scans on registry
Unregsiter duplicate (listening to the same topic) subscriptions individually
…njos/unbounded_concurrency_fix
…currency_fix Add async option to Absinthe.Subscription
This fixes an issue when you have types declared in a Prototype (such as input_object input types for a directive). Previously type resolution would look on the Schema, but not the Prototype for the type definitions. You _could_ workaround this by duplicating your type definition into both the Schema and the Prototype. This makes me somewhat curious if there is a better way to fix this, in that the code that was trying to resolve the type here shouldn't be resolving it on the Schema, but rather on the Prototype 🤷. This seems to work though. Fixes #1279
…tion Fix type resolution by recursing prototypes
…turn_maps Allow config/2 to send errors in spec compliant format
…-pool-size-documentation [#1342] Add note on the need of fixed :pool_size to guide
Instead of producing an eritrary log message with an arbitrary level, emit a telemetry event [:absinthe, :middleware, :batch, :timeout], so everyone can subscribe to it and do whatevet they want (including logging the same message as was here before).
Proposal: Telemetry event instead of predefined log message on batch timeout
…timeout Use exit/1 instead of Process.exit/2 on batch timeout
List of changes: - Bump GitHub actions - Enable back OTP 25 / Elixir 1.17 in test matrix - Resolve dialyzer errors in Elixir 1.18 - Remove duplicate check on main branch upon a pull request - Support Elixir 1.18 to CI
CI housekeeping
michaelcaterisano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to merge this PR, this is so we can see the diff before switching directly to absinthe v1.7.9