Skip to content

Conversation

@bryanjos
Copy link
Contributor

@bryanjos bryanjos commented Jun 20, 2024

  • Create a behaviour named Absinthe.Subscription.DocumentStorage to allow customization around how Absinthe stores subscription documents and field key pairs.
  • Create an implementation named, Absinthe.Subscription.DefaultDocumentStorage implemented using the Registry and algorithms Absinthe used previously
  • Update Absinthe.Subscription.Supervisor to check for a storage key in its opts. The default value is Absinthe.Subscription.DefaultDocumentStorage
  • Update Absinthe.Subscription to use the configured storage module

@bryanjos bryanjos marked this pull request as ready for review June 21, 2024 14:46
@bryanjos bryanjos marked this pull request as draft June 21, 2024 16:39
@bryanjos bryanjos marked this pull request as ready for review June 21, 2024 17:07
Copy link

@GeoffreyPS GeoffreyPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some feedback on things that confused me or seemed a little awkward.

I think exposing this as a behavior is a great idea, so I agree with the direction you're taking this.

@bryanjos
Copy link
Contributor Author

@benwilson512 @maartenvanvliet Hey we're looking to add support for customizing how Absinthe stores subscription documents in our fork. But we also want to make sure it's going in a direction that it can be added into Absinthe proper. Do you all mind looking and giving any feedback?

@bryanjos
Copy link
Contributor Author

I think I might have overthought this. Instead, people can just implement the behaviour, tell Absinthe what module to use and then they can start any processes they need before starting Absinthe.Subscription
#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants