-
Notifications
You must be signed in to change notification settings - Fork 0
[GRAPH-1102] Customizable doc storage with default implementation #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
GeoffreyPS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some feedback on things that confused me or seemed a little awkward.
I think exposing this as a behavior is a great idea, so I agree with the direction you're taking this.
|
@benwilson512 @maartenvanvliet Hey we're looking to add support for customizing how Absinthe stores subscription documents in our fork. But we also want to make sure it's going in a direction that it can be added into Absinthe proper. Do you all mind looking and giving any feedback? |
|
I think I might have overthought this. Instead, people can just implement the behaviour, tell Absinthe what module to use and then they can start any processes they need before starting |
Absinthe.Subscription.DocumentStorageto allow customization around how Absinthe stores subscription documents and field key pairs.Absinthe.Subscription.DefaultDocumentStorageimplemented using the Registry and algorithms Absinthe used previouslyAbsinthe.Subscription.Supervisorto check for astoragekey in itsopts. The default value isAbsinthe.Subscription.DefaultDocumentStorageAbsinthe.Subscriptionto use the configured storage module