Fix/file delete #25
Open
Fix/file delete #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonnedejong-uk
changed the base branch from
main
to
feature/storage-brokering
marcuslowndes
changed the base branch from
feature/storage-brokering
to
fix/file-download
marcuslowndes
changed the base branch from
fix/file-download
to
feature/storage-brokering
Comment on lines
122
to
134
| @@ -129,26 +130,33 @@ def locate(self, filename) -> object: | |||
| files = response.get("children", []) or response.get("entries", []) | |||
| for f in files: | |||
| if f.get("name") == filename: | |||
| return f.get("id") | |||
|
|
|||
| self._set_file_id(f.get("file_id")) | |||
| return f.get("file_id") | |||
Collaborator
There was a problem hiding this comment.
@yvonnedejong-uk So, as I mentioned today, we shouldn't just do a "get all" of the entire directory on OneData. We should do a direct search in OneData for that file name in OneData (if possible)
As we discussed, there will not be multiple files with the same name in the same directory, so we don't need to worry about that
Collaborator
There was a problem hiding this comment.
Handing back to you
* file download function * Bring back upload file test and add find file test * Separate provisioning tests from file mgmt tests * revert unnecessary change * Update deletable file ID env name for clarity --------- Co-authored-by: marcuslowndes <marcuslowndes@yahoo.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testcase: Delete file function to OneData