Skip to content

Conversation

@xupengpeng02
Copy link

Summary

  1. No longer enforce Cl to be Cl-.
  2. For "merge glycine" functionality, add the edge case: when the first fragment contains glycine, do not merge
  3. fix a KeyError in fragmentation.py
  4. add DFTB HMO file

@cstein
Copy link
Member

cstein commented Aug 12, 2025

Hi Peng,

I will adjust slightly, especially for the Cl- vs Cl case. I completely understand what you want to achieve. Problem is that it then breaks all simulations in solution where Cl- is used as a counter ion.

I will find a solution. Thanks for catching the bugs also :)

Best

Casper

@xupengpeng02
Copy link
Author

xupengpeng02 commented Sep 11, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants