Refactor plotting functions with separated computational/visualization logic #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n logic - Separate pure computational functions (calculate_*) from plotting functions (plot_*) - Implement robust CI-compatible testing pattern - Test mathematical logic directly without try-catch masking errors - Use try-catch only for plotting/visualization components - Maintain backward compatibility for all existing function signatures - Update copilot-instructions.md with complete Math_Foundations CI approach - All 75 tests pass with improved architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the superior Math_Foundations CI testing approach by separating computational logic from plotting visualization.
Key Improvements:
calculate_*) separate from plotting functions (plot_*)Architecture Changes:
calculate_parabola_roots_*functions for pure mathematical computationplot_parabola_roots_*functions to return real roots only (backward compatible)Test Results:
All 75 tests pass ✅
Ready for Linear_Algebra conversion: This approach is now proven and documented for replication.