Add comprehensive test suite for basic_maths.jl #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AronT-TLV
commented
Jul 21, 2025
AronT-TLV
commented
- Add 54 comprehensive tests covering all mathematical functions
- Test nth_root function with positive/negative numbers and edge cases
- Test expa2x function with various inputs and error handling
- Test financial functions (accrued, accrued_apr) with realistic scenarios
- Test triangle_area_perim function with various triangle types
- Test plotting functions to ensure they execute without errors
- Export missing functions (nth_root, triangle_area_perim) from module
- Update test infrastructure to use Math_Foundations package properly
- All tests passing successfully
- Add 54 comprehensive tests covering all mathematical functions - Test nth_root function with positive/negative numbers and edge cases - Test expa2x function with various inputs and error handling - Test financial functions (accrued, accrued_apr) with realistic scenarios - Test triangle_area_perim function with various triangle types - Test plotting functions to ensure they execute without errors - Export missing functions (nth_root, triangle_area_perim) from module - Update test infrastructure to use Math_Foundations package properly - All tests passing successfully
- Configure GKS for headless operation in CI environments - Add smart environment detection (CI vs interactive) - Set ENV["GKSwstype"] = "100" for headless mode in module - Update test configuration for headless plotting support - Ensure all tests pass in both interactive and headless environments
AronT-TLV
force-pushed
the
feature/add-basic-maths-tests
branch
from
de43291 to
4b8fd57
Compare
- Remove unused Nemo package (~500MB) from test dependencies - Remove unused Reexport package from test dependencies - Keep essential packages: Symbolics (for hyperbola functions), Polynomials (for polynomial functions) - Replace @quickactivate with explicit load path management in tests - Fix CI test execution to work with separate test Project.toml - All 54 tests still pass with reduced dependency footprint - Significantly faster CI builds due to smaller cache size
- Remove separate test/Project.toml (was pointless since main module loads Nemo anyway) - Restore @quickactivate in test/runtests.jl - Restore simple CI configuration without complex caching - Consolidate .github/copilot/instructions.md into .github/copilot-instructions.md - Add git staging best practices to prevent accidental commits - Tests still pass (54/54) and CI will work as originally designed - Accept that CI will be slower due to Nemo dependency (unavoidable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.