feat(light): DDA voxel shadow occlusion for point and area lights #108
Merged
Ocelot5836 merged 17 commits intoFoundryMC:next/1.21from Mar 1, 2026
Merged
feat(light): DDA voxel shadow occlusion for point and area lights #108Ocelot5836 merged 17 commits intoFoundryMC:next/1.21from
Ocelot5836 merged 17 commits intoFoundryMC:next/1.21from
Conversation
Ocelot5836
requested changes
Mar 1, 2026
Collaborator
Ocelot5836
left a comment
Ocelot5836
left a comment
There was a problem hiding this comment.
This pr looks good! Once you make those changes I'll go ahead and merge
common/src/main/java/foundry/veil/api/client/render/light/data/AreaLightData.java
Outdated
Show resolved
Hide resolved
common/src/main/java/foundry/veil/api/client/render/ext/VeilMultiBind.java
Show resolved
Hide resolved
common/src/main/java/foundry/veil/api/client/render/ext/VeilMultiBind.java
Outdated
Show resolved
Hide resolved
common/src/main/java/foundry/veil/api/client/render/VeilRenderSystem.java
Outdated
Show resolved
Hide resolved
Collaborator
|
If you remove the changes to common/src/main/java/foundry/veil/api/client/render/ext/VeilMultiBind.java I'll be able to rebase and merge |
Contributor
Author
|
Oops, i don't know what i've done but i just removed the changes |
Contributor
Author
In the fixing conflict commit |
Contributor
Author
|
Huh |
Collaborator
|
Oh, remove the second copy of this |
Contributor
Author
What???
|
# Conflicts: # common/src/main/java/foundry/veil/api/client/render/ext/VeilMultiBind.java
Contributor
Author
|
Perfect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a camera-centered voxel shadow grid that point and area lights can use for cheap occlusion testing via a DDA ray march*
The occlusion per-light is toggelable and the grid is only built and bound when at least one light has occlusion enabled
And some changes to the Multibind cache so it avoid repeated target lookups on every bind call