Add location and participant parsing to calendar events #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add UnescapeICSText helper to properly decode RFC 5545 escaped text (handles \n, \\, \,, \; escape sequences) - Add Location field to ICalendarEvent struct - Add Attendees list to ICalendarEvent struct - Parse LOCATION property with proper text unescaping - Parse ATTENDEE properties, extracting CN parameter and mailto: address, formatting as "Name <email>" or just email - Expose location and participants fields in Event model JSON
Extract the ATTENDEE line parsing logic into a separate inline function for improved readability. Also revert Event.cpp changes - the location and participants fields will be attached to the event system separately.
Security fixes for untrusted ICS data from external CalDAV servers: - Prevent CN parameter injection by only searching for CN= in the parameter section (before the colon), not in the email address portion - Use case-insensitive matching for CN= per RFC 5545 Section 3.1 - Use case-insensitive matching for mailto: per RFC 3986 - Handle malformed lines (missing colon) gracefully - Add security documentation comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to parse these on the C++ side to populate the EventSearch table properly.