Fade cancel

.all-contributorsrc

@@ -338,6 +338,173 @@
       "contributions": [
         "code"
       ]
+    },
+    {
+      "login": "tustin2121",
+      "name": "tustin2121",
+      "avatar_url": "https://avatars.githubusercontent.com/u/794812?v=4",
+      "profile": "https://tustin2121.github.io/",
+      "contributions": [
+        "doc",
+        "code"
+      ]
+    },
+    {
+      "login": "Ddaretrogamer",
+      "name": "Phantonomy",
+      "avatar_url": "https://avatars.githubusercontent.com/u/131238004?v=4",
+      "profile": "https://github.com/Ddaretrogamer",
+      "contributions": [
+        "design"
+      ]
+    },
+    {
+      "login": "Syreldar",
+      "name": "Enrico Drago",
+      "avatar_url": "https://avatars.githubusercontent.com/u/42327659?v=4",
+      "profile": "https://metin2.dev/index.php",
+      "contributions": [
+        "doc",
+        "userTesting"
+      ]
+    },
+    {
+      "login": "Pyredrid",
+      "name": "Pyredrid",
+      "avatar_url": "https://avatars.githubusercontent.com/u/8324784?v=4",
+      "profile": "https://github.com/Pyredrid",
+      "contributions": [
+        "userTesting",
+        "maintenance"
+      ]
+    },
+    {
+      "login": "mvit",
+      "name": "mv",
+      "avatar_url": "https://avatars.githubusercontent.com/u/128863?v=4",
+      "profile": "https://github.com/mvit",
+      "contributions": [
+        "code",
+        "design"
+      ]
+    },
+    {
+      "login": "Mother-Of-Dragons",
+      "name": "Avara",
+      "avatar_url": "https://avatars.githubusercontent.com/u/31101124?v=4",
+      "profile": "https://github.com/Mother-Of-Dragons",
+      "contributions": [
+        "data"
+      ]
+    },
+    {
+      "login": "Doesnty",
+      "name": "Doesnty",
+      "avatar_url": "https://avatars.githubusercontent.com/u/6163136?v=4",
+      "profile": "https://github.com/Doesnty",
+      "contributions": [
+        "design"
+      ]
+    },
+    {
+      "login": "FosterProgramming",
+      "name": "FosterProgramming",
+      "avatar_url": "https://avatars.githubusercontent.com/u/178871164?v=4",
+      "profile": "https://github.com/FosterProgramming",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "Squeetz",
+      "name": "Squeetz",
+      "avatar_url": "https://avatars.githubusercontent.com/u/21145213?v=4",
+      "profile": "https://github.com/Squeetz",
+      "contributions": [
+        "maintenance"
+      ]
+    },
+    {
+      "login": "ghostyboyy97",
+      "name": "ghostyboyy97",
+      "avatar_url": "https://avatars.githubusercontent.com/u/106448956?v=4",
+      "profile": "https://github.com/ghostyboyy97",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "HashtagMarky",
+      "name": "Marky",
+      "avatar_url": "https://avatars.githubusercontent.com/u/143505183?v=4",
+      "profile": "http://hashtagmarky.github.io",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "MandL27",
+      "name": "MandL27",
+      "avatar_url": "https://avatars.githubusercontent.com/u/10366615?v=4",
+      "profile": "https://github.com/MandL27",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "cawtds",
+      "name": "cawtds",
+      "avatar_url": "https://avatars.githubusercontent.com/u/38510667?v=4",
+      "profile": "https://github.com/cawtds",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "fdeblasio",
+      "name": "Frank DeBlasio",
+      "avatar_url": "https://avatars.githubusercontent.com/u/35279583?v=4",
+      "profile": "https://github.com/fdeblasio",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "leo60228",
+      "name": "leo60228",
+      "avatar_url": "https://avatars.githubusercontent.com/u/8355305?v=4",
+      "profile": "https://vriska.dev",
+      "contributions": [
+        "doc",
+        "data"
+      ]
+    },
+    {
+      "login": "shachar700",
+      "name": "shachar700",
+      "avatar_url": "https://avatars.githubusercontent.com/u/48739719?v=4",
+      "profile": "https://github.com/shachar700",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "purrfectdoodle",
+      "name": "Eva",
+      "avatar_url": "https://avatars.githubusercontent.com/u/105788407?v=4",
+      "profile": "http://purrfectdoodle.com",
+      "contributions": [
+        "design"
+      ]
+    },
+    {
+      "login": "amiosi",
+      "name": "amiosi",
+      "avatar_url": "https://avatars.githubusercontent.com/u/44352097?v=4",
+      "profile": "https://github.com/amiosi",
+      "contributions": [
+        "data"
+      ]
     }
   ],
   "contributorsPerLine": 7,

.gitattributes

@@ -18,6 +18,9 @@ Makefile text eol=lf
 *.md text eol=lf
 *.ps1 text eol=crlf
 *.yml text eol=lf
+*.party text eol=lf
+*.cfg text eol=lf
+*.ld text eol=lf
 
 *.png binary
 *.bin binary

.github/ISSUE_TEMPLATE/01_battle_engine_bugs.yaml

@@ -7,6 +7,7 @@ body:
       value: |
         Please fill in all fields with as many details as possible.
         Once your bug is posted, make sure you and your collaborators are added to `CREDITS.md` by [tagging the bot on GitHub](https://github.com/rh-hideout/pokeemerald-expansion/wiki/CREDITS.md-Frequently-Asked-Questions). EVERY contribution matters, even reporting bugs!
+  - type: textarea         
     id: description
     attributes:
       label: Description
@@ -42,15 +43,16 @@ body:
       label: Version
       description: What version of pokeemerald-expansion are you using?
       options:
-        - 1.12.0 (Latest release)
+        - 1.14.1 (Latest release)
         - master (default, unreleased bugfixes)
         - upcoming (Edge)
-        - 1.11.4
-        - 1.11.3
-        - 1.11.2
-        - 1.11.1
-        - 1.11.0
-        - pre-1.11.0
+        - 1.14.0
+        - 1.13.4
+        - 1.13.3
+        - 1.13.2
+        - 1.13.1
+        - 1.13.0
+        - pre-1.13.0
     validations:
       required: true
   - type: input

.github/ISSUE_TEMPLATE/02_battle_ai_issues.yaml

@@ -43,15 +43,16 @@ body:
       label: Version
       description: What version of pokeemerald-expansion are you using?
       options:
-        - 1.12.0 (Latest release)
+        - 1.14.1 (Latest release)
         - master (default, unreleased bugfixes)
         - upcoming (Edge)
-        - 1.11.4
-        - 1.11.3
-        - 1.11.2
-        - 1.11.1
-        - 1.11.0
-        - pre-1.11.0
+        - 1.14.0
+        - 1.13.4
+        - 1.13.3
+        - 1.13.2
+        - 1.13.1
+        - 1.13.0
+        - pre-1.13.0
     validations:
       required: true
   - type: input

.github/ISSUE_TEMPLATE/04_other_errors.yaml

@@ -43,14 +43,16 @@ body:
       label: Version
       description: What version of pokeemerald-expansion are you using?
       options:
-        - 1.12.0 (Latest release)
+        - 1.14.1 (Latest release)
         - master (default, unreleased bugfixes)
         - upcoming (Edge)
-        - 1.11.4
-        - 1.11.3
-        - 1.11.1
-        - 1.11.0
-        - pre-1.11.0
+        - 1.14.0
+        - 1.13.4
+        - 1.13.3
+        - 1.13.2
+        - 1.13.1
+        - 1.13.0
+        - pre-1.13.0
     validations:
       required: true
   - type: input

.github/docs_validate/inclusive_summary.py

@@ -0,0 +1,64 @@
+#!/usr/bin/python3
+
+"""
+Checks that all documentation pages that should be mentioned in
+`docs/SUMMARY.md` are mentioned the file
+"""
+
+import glob
+import re
+import os
+from pathlib import Path
+
+errorLines = []
+
+if not os.path.exists("Makefile"):
+    errorLines.append("Please run this script from your root folder.")
+
+summaryFile = Path("docs/SUMMARY.md")
+if not errorLines:
+    if not summaryFile.is_file():
+        errorLines.append("docs/SUMMARY.md missing")
+
+summaryContents = []
+if not errorLines:
+    with open(summaryFile, 'r', encoding='UTF-8') as file:
+        entry_pattern = re.compile(r" *\- \[[^\]]*\]\(([^\)]*)\)\n")
+        lineNo = 0
+        while line:=file.readline():
+            lineNo = lineNo + 1
+            if line == "# Summary\n" or line == "\n":
+                pass
+            elif match:=entry_pattern.match(line):
+                if "" != match.group(1):
+                    summaryContents.append(Path(match.group(1)))
+            else:
+                if not errorLines:
+                    errorLines.append("## Unexpected lines in docs/SUMMARY.md")
+                errorLines.append(f"- {lineNo}: {line.strip()}")
+
+if not errorLines:
+    for pathName in glob.glob("**/*.md", root_dir="docs", recursive=True):
+        path = Path(pathName)
+        if path == Path("SUMMARY.md"):
+            pass
+        elif path == Path("changelogs/template.md"):
+            pass
+        elif path in summaryContents:
+            pass
+        else:
+            if not errorLines:
+                errorLines.append("## `docs/**/*.md` files present but not mentioned in `docs/SUMMARY.md`")
+            errorLines.append("- " + str(path))
+
+if errorLines:
+    for line in errorLines:
+        print(line)
+
+    if 'GITHUB_STEP_SUMMARY' in os.environ:
+        with open(os.environ['GITHUB_STEP_SUMMARY'], 'w', encoding='UTF-8') as file:
+            for line in errorLines:
+                file.write(line)
+                file.write('\n')
+
+    quit(1)

.github/pull_request_template.md

@@ -24,6 +24,7 @@
 <!-- CREDITS -->
 <!-- Once your PR is submitted, leave a comment asking the bot to add you to the credits. -->
 <!-- If anybody helped with this PR, please encourage them to comment on your PR and ask the bot to add them to the credits. -->
+<!-- If somebody has contributed at any point and has indicated they wish to be credited, please ask the bot to add them to the credits. If they do not have a known GitHub account, add them to the list at bottom of `CREDITS.md`. -->
 <!-- EVERY contribution matters! -->
 <!-- https://github.com/rh-hideout/pokeemerald-expansion/wiki/CREDITS.md-Frequently-Asked-Questions -->
 

.github/workflows/build.yml

@@ -31,12 +31,30 @@ jobs:
         env:
           COMPARE: 0
         run: make -j${nproc} -O all
+
+      - name: LTO
+        run: |
+          make tidy
+          make -j${nproc} LTO=1
+        # make tidy to purge previous build
 
       - name: Test
         env:
           TEST: 1
         run: |
           make -j${nproc} check
+
+  docs_validate:
+    if: github.actor != 'allcontributors[bot]'
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Check that SUMMARY.md includes markdown doc files
+        run: |
+          .github/docs_validate/inclusive_summary.py
+
   allcontributors:
     if: github.actor == 'allcontributors[bot]'
     runs-on: ubuntu-latest

.github/workflows/docs.yml

@@ -17,7 +17,7 @@ jobs:
           fetch-depth: 0
       - name: Install latest mdbook
         run: |
-          tag=$(curl 'https://api.github.com/repos/rust-lang/mdbook/releases/latest' | jq -r '.tag_name')
+          tag="v0.5.1"
           url="https://github.com/rust-lang/mdbook/releases/download/${tag}/mdbook-${tag}-x86_64-unknown-linux-gnu.tar.gz"
           mkdir mdbook
           curl -sSL $url | tar -xz --directory=./mdbook

.github/workflows/labels.yml

@@ -3,10 +3,12 @@ name: Labels
 on:
   pull_request:
     types: [opened, synchronize, labeled, unlabeled]
+  pull_request_review:
+    types: [submitted]
 
 jobs:
   label:
-    if: github.actor != 'allcontributors[bot]'
+    if: ${{ github.actor != 'allcontributors[bot]' && github.event.review.state == 'approved' }}
     runs-on: ubuntu-latest
     steps:
       - name: check labels