Skip to content

fix: use safe call when accessing fragment methods #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 1 commit into from
Jun 3, 2025
Merged

fix: use safe call when accessing fragment methods #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions app/src/main/kotlin/org/fossify/contacts/activities/InsertOrEditContactActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ class InsertOrEditContactActivity : SimpleActivity(), RefreshContactsListener {

binding.insertEditMenu.onSearchClosedListener = {
getAllFragments().forEach {
it.onSearchClosed()
it?.onSearchClosed()
}
}

Expand Down Expand Up @@ -139,7 +139,7 @@ class InsertOrEditContactActivity : SimpleActivity(), RefreshContactsListener {
override fun onPageSelected(position: Int) {
binding.insertEditTabsHolder.getTabAt(position)?.select()
getAllFragments().forEach {
it.finishActMode()
it?.finishActMode()
}
}
})
Expand Down Expand Up @@ -199,7 +199,12 @@ class InsertOrEditContactActivity : SimpleActivity(), RefreshContactsListener {
}
}

private fun getAllFragments() = arrayListOf<MyViewPagerFragment<*>>(findViewById(R.id.contacts_fragment), findViewById(R.id.favorites_fragment))
private fun getAllFragments(): ArrayList<MyViewPagerFragment<*>?> {
return arrayListOf<MyViewPagerFragment<*>?>(
findViewById(R.id.contacts_fragment),
findViewById(R.id.favorites_fragment)
)
}

private fun setupTabColors() {
val activeView = binding.insertEditTabsHolder.getTabAt(binding.viewPager.currentItem)?.customView
Expand Down
Loading