Improve separate preview window UX #608
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When detaching the preview to a separate window: - Automatically switch to 'Editor only' mode to maximize useful space - Eliminate the useless placeholder panel that required extra clicks - Add toolbar to detached window (without detach action) When attaching the preview back to the editor: - Automatically restore 'Split' mode to show the preview This change connects the XamlSplitEditor parent to the preview editors, allowing them to control the layout mode. Technical notes: - Toolbar and preview wrapped in contentPanel to preserve window decorations - Added getExtraActions() abstract method for subclass-specific toolbar actions Modified files: - AvaloniaPreviewEditorBase.kt: Added parentEditor, layout calls, detached toolbar - AvaloniaRemotePreviewEditor.kt: Pass parentEditor, implement getExtraActions - AvaloniaHtmlPreviewEditor.kt: Pass parentEditor, implement getExtraActions - AvaloniaPreviewerXamlEditorExtension.kt: Pass parent to constructors
Contributor
Author
|
@ForNeVeR Please, review this PR to see if it's OK or not. Tried my best to make it functionally acceptable. Tested locally. It seems to work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the user experience when using the detached preview window feature:
Changes
Auto-switch to Editor Only mode: When detaching the preview to a separate window, the IDE automatically switches to 'Editor Only' mode to maximize usable space (no empty placeholder panel).
Auto-restore Split mode: When closing the detached window or clicking 'Return to editor', the IDE restores the 'Split' layout.
Add 'Open Preview in Window' action: A new action is available in the editor context menu and tab context menu to open the preview in a separate window. The action is also programmatically injected into the split editor toolbar for better discoverability.
Use WindowWrapper API: Refactored to use IntelliJ's
WindowWrapperBuilderfor better integration.Fix window decorations on Linux: Ensures the detached window has proper title bar and decorations.
Technical Notes
UIUtil.uiTraverserto find and modify the parent editor's toolbar, as Rider doesn't expose a public ActionGroup ID for the XAML split editor toolbar.DimensionService.