Open
Conversation
Owner
|
I think the cleanup of the paramObj is good, but I don't think we want a notebook like this in the master branch. If the notebook would be more like a short tutorial I would be okay with it, but this looks to much like a debugging notebook to me. |
Collaborator
Author
|
Yeah, this was just to show you how to use the module in a notebook, and more of a wrking branch. The paramObj cleanup is already in master independently of this pull request. I might add some more tries at finding the bad frequencies here. It seems that Tammo-jan does this manually (?), at least this is the impression I get from his waterfallplots. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.