Simplify menu partial, remove "settings", make it easier to override default paritial#3
Open
that0n3guy wants to merge 7 commits intoFlynsarmy:masterfrom
Open
Simplify menu partial, remove "settings", make it easier to override default paritial#3that0n3guy wants to merge 7 commits intoFlynsarmy:masterfrom
that0n3guy wants to merge 7 commits intoFlynsarmy:masterfrom
Conversation
Author
|
I just fixed the issue w/ disabled menu items showing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies things a little bit, but is NOT backwords compatable (but thats good). It makes it so that the user can use whatever format they want for displaying the menu. They can override the default menu partial two different "october" ways. Those 2 ways are listed in the default.htm file:
This makes the "settings" pointless now.