Skip to content

Make it not crash on android#12

Open
trustytrojan wants to merge 2 commits intoFlutterish:mainfrom
trustytrojan:fix-android
Open

Make it not crash on android#12
trustytrojan wants to merge 2 commits intoFlutterish:mainfrom
trustytrojan:fix-android

Conversation

@trustytrojan
Copy link

The usual deal of the lazer APK trimming out unused classes/methods from the bundled .NET runtime
Still have this one left but it isn't causing a crash upon pressing the report/webpage buttons on ruleset details.

System.MissingMethodException: Method not found: void osu.Game.OsuGame.OpenUrlExternally(string,bool)

@Flutterish
Copy link
Owner

Why are we not using GetEndpoint anymore? String concat with paths is very error prone. Otherwise I think it looks good.

@trustytrojan
Copy link
Author

Why are we not using GetEndpoint anymore? String concat with paths is very error prone. Otherwise I think it looks good.

Changed it back, no effect on behavior. Made the change because OsuJsonWebRequest's constructor only accepted a string and I didn't know about the AbsoluteUri property on Uri objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants