Add test coverage for version resolution mechanism #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for: - _dependenciesFromJson parsing in pubspec.dart (string versions, map versions, path/git dependencies, invalid versions, null dependencies, mixed formats) - Integration version constraint collection in config.dart (from pubspec.yaml and pubspec.lock) - Version resolution priority and edge cases Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
Test version resolution with various constraint formats and validate the integration with AssetsGenConfig Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
- Replace meaningless null key check with proper validation of expected integration types - Clarify comment about version resolution priority Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
- Use consistent dependency format in test resources - Import and use integrationPackages registry instead of hardcoding types Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for Rive 0.14 integration
Add test coverage for version resolution mechanism
Dec 29, 2025
Member
Moved test resources into subdirectories with standard pubspec.yaml/pubspec.lock names. This fixes the issue where loadPubspecConfig expects pubspec.lock in the same directory as pubspec.yaml, not with custom names. Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
Force-add the lock files that were excluded by gitignore. These test resources need lock files to test version resolution. Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
Changed from basename(pubspecFile.parent.path) to pubspecFile.parent.path to correctly resolve pubspec.lock location. The basename() call was stripping directory structure, causing lock files in subdirectories to not be found. Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
Apply same fix to analysis_options.yaml path - use full parent path instead of basename to correctly locate the file. Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
Author
Fixed in commits f02b252 and 7f88429. The issue was in the path resolution logic for Also reorganized test resources into subdirectories with standard Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Failure Investigation and Fixes
Changes Made
Path Resolution Bugs Fixed:
pubspec.lockpath resolution inconfig.dart- changed frombasename(pubspecFile.parent.path)topubspecFile.parent.pathanalysis_options.yamlpath resolution similarlyTest Resources Reorganized:
pubspec.yaml/pubspec.locknaming:test_resources/integration_versions/for Rive 0.13.xtest_resources/integration_versions_rive_014/for Rive 0.14.x.lockfiles (excluded by gitignore but needed for tests)Test Coverage:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.