Conversation
Tarazicon
requested review from
M3739,
Memeji and
Mnemotechnician
as code owners
github-actions
bot
added
size/XL
Changes: YML
Changes: C#
Changes: Localization
and removed
size/XL
labels
|
…ky, oh and get rid of a dupped scent
Mnemotechnician
left a comment
Mnemotechnician
left a comment
There was a problem hiding this comment.
Don't hardcode behaviors in the TraitPrototype. Create a new TraitEffect (see language trait effects for example).
| // Euphoria edit: Port Coyote scent mechanic. Thank DeltaV for wanting to be unique because this is so confusing. | ||
| var scentComp = EnsureComp<ScentComponent>(args.Mob); | ||
| foreach (var trait in sortedPrototypes) | ||
| { | ||
| foreach (var scentProtoID in trait.Scents) | ||
| { | ||
| _scentSystem.AddScentPrototype(scentComp, scentProtoID); | ||
| } | ||
| } | ||
| // Euphoria edit end | ||
|
|
There was a problem hiding this comment.
Blame me for this one.
There was a problem hiding this comment.
i'd like some emphasis, since i hardly know c# enough to fix it
|
|
||
| /// <summary> | ||
| /// Scents! | ||
| /// </summary> | ||
| [DataField("scentProtos")] | ||
| public List<ProtoId<ScentPrototype>> Scents = new(); |
There was a problem hiding this comment.
i'd like some emphasis, since i hardly know c# enough to fix it
There was a problem hiding this comment.
i'd like some emphasis, since i hardly know c# enough to fix it
They said to look in language trait effects for examples. I can help...way late tonight probably (work thing tonight)
There was a problem hiding this comment.
See ReplaceNaturalLanguageTraitEffect and language traits (hyperlinks)
|
|
||
| - type: traitCategory | ||
| id: Scents | ||
| name: trait-category-scents | ||
| priority: 60 | ||
| maxTraits: 2 | ||
| accentColor: "#52ffc2" # Mint Green | ||
|
|
||
| - type: traitCategory | ||
| id: ScentsNSFW | ||
| name: trait-category-scents-nsfw | ||
| priority: 70 | ||
| maxTraits: 2 | ||
| accentColor: "#ff1778" # Hot Pink |
There was a problem hiding this comment.
This should go in _Floof and be collapsed by default if you're going to add lots of traits in there
There was a problem hiding this comment.
how would i make them collapsed by default?
There was a problem hiding this comment.
defaultExpanded: false
4 participants
About the PR
This PR adds a new trait category: SCENTS!
Essentially, you can smell people now.
HEY! This comes with a consent toggle too! Don't worry!
This is a near-1:1 port of this PR from Coyote.
This has been hell to even try.
Why / Balance
What's a healthy work environment without catching a whiff of your favorite co-worker's cologne/deodorant/perfume and/or musk?
Adds lots of RP potential, plus, it's funny to run up to your boss to sniff them.
Technical details
oh god where do i start
C# AND LOTS OF YAML CHANGES.
THIS IS MY FIRST EVER EXPERIENCE WITH C#. EXPECT SOME SHITCODE.
IF I HAVE DONE SOMETHING WRONG, PLEASE TELL ME, AND I WILL FIX IT ASAP. And please be nice, I really don't do well with harsh comments.
Had to change a few things relating to
TraitSystem.csandTraitPrototype.csto accommodate for the new scent features, as they were missing some values from Coyote.Also didn't port the weird popup nonsense that the other PR did, as it was confusing and didn't seem like it would work.
Credits to @ScarlettJFG for helping me get past one stubborn error due to Delta-V's new trait systems.
Media
Click to show
ough.
Categories, sniffing others with/without consent toggle, said consent toggle, sniffing yourself, and examines.
Requirements
Licensing:
Breaking changes
Changelog
🆑