Conversation
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
|
Looks okay, but I would recommend that this trait be incompatible with all the breast traits. Currently you can take normal breasts and honey with this build. |
I was unsure where honey would come from, and defaulted to breast. I've left it un-exclusive if the individual using the trait IC expels honey from a different organ, like mouth or cock or whatever. |
I understand, but why then exclude one type of breast? Also, do we really want people to be able to make characters than can expel so much fluid they turn themselves into beef jerky? What's to stop them taking everything? |
I'm not sure what you mean by the first half of that but, I'm not about to question someones cumflation or hyper kinks. For the purpose of ERP, you produce honey. That's all it has to bee. Also I don't take cock on a character that doesn't have a cock, that would be the simple limiting factor. Common sense. If your character doesn't make honey, then they don't. |
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
|
That's a ton of copypaste |
There was a problem hiding this comment.
This is awful, you are duplicating a component, an event, and entity system logic for... no reason at all? This entire PR could be a total of 20 lines, instead it's 160 and introduces a new unnecessary update loop.
Just override MilkProducerComponent with a different produced reagent.
Yes, there was a reason, I didn't want to override MilkProducerComponent because you can't take both normal breast and honey then and last time I did that, the egg producer trait broke Arachne making webs because I used the same comp. Plus it's just how the sex traits were coded, I don't exactly have a better example to work off. |
You made the honey thing add reagents to and draw reagents from the "breast" solution, so you've already introduced the same kind of bug you're talking about.
There is no good example. A proper implementation of this would require rewriting the lewd trait system to support arbitrary reagent generation and containment. However, "there is already a lot of bad code" is not a justification to add even more bad code. |
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
About the PR
Added a trait using the breast/cum system that makes Honey. I wasn't sure where honey would come from so it says breast.
Changelog
🆑