Trait profile saving fix (maybe)#304
Open
SyaoranFox wants to merge 6 commits intoFloof-Station:masterfrom
Open
Trait profile saving fix (maybe)#304SyaoranFox wants to merge 6 commits intoFloof-Station:masterfrom
SyaoranFox wants to merge 6 commits intoFloof-Station:masterfrom
Conversation
This reverts commit 0a921d8.
Collaborator
|
Has this been tested? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Force the system to select the correct profile to save, thus preventing changes from being discarded.
Why / Balance
Sometimes traits wouldn't be saved. It was an issue for admins.
Technical details
took the profile selection code from UpdateConditions so that it can be called before UpdateTraitSelection. I didn't remove the old profile selection code, as it still worked properly, just sometimes it would be called too late. _profile = profile twice shouldn't have an impact anywhere.
Media
Click to show
Requirements
Licensing:
Breaking changes
Changelog
🆑!