Skip to content

Trait profile saving fix (maybe)#304

Open
SyaoranFox wants to merge 6 commits intoFloof-Station:masterfrom
SyaoranFox:traitFix
Open

Trait profile saving fix (maybe)#304
SyaoranFox wants to merge 6 commits intoFloof-Station:masterfrom
SyaoranFox:traitFix

Conversation

@SyaoranFox
Copy link
Copy Markdown
Contributor

About the PR

Force the system to select the correct profile to save, thus preventing changes from being discarded.

Why / Balance

Sometimes traits wouldn't be saved. It was an issue for admins.

Technical details

took the profile selection code from UpdateConditions so that it can be called before UpdateTraitSelection. I didn't remove the old profile selection code, as it still worked properly, just sometimes it would be called too late. _profile = profile twice shouldn't have an impact anywhere.

Media

Click to show

Example Media Embed

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Licensing:

Breaking changes

Changelog

🆑!

  • fix: Maybe fixed the saving trait bug where languages would not be applied to the character

@Mnemotechnician
Copy link
Copy Markdown
Collaborator

Has this been tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants