This repository was archived by the owner on May 31, 2021. It is now read-only.
WIP: Handle faults returned from rtorrent#841
Open
wheelerlaw wants to merge 4 commits intoFlood-UI:masterfrom
Open
WIP: Handle faults returned from rtorrent#841wheelerlaw wants to merge 4 commits intoFlood-UI:masterfrom
wheelerlaw wants to merge 4 commits intoFlood-UI:masterfrom
Conversation
3 tasks
Author
|
So with the changes, the original error message makes it back to the client, but I still need to build in some functionality into the add files modal to handle errors from the server. |
Member
|
Oh I just realized you're planning to add on to this, I'll dismiss my approval |
Contributor
|
Any idea what happened before ccf4688 ? did it just swallow the error as well? |
jesec
pushed a commit
to jesec/flood
that referenced
this pull request
Feb 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When rtorrent encounters an error interacting with the xmlrpc interface, it will return a response with a
<fault>...</fault>tag in the response body. Currently Flood doesn't handle this tag in the rtorrentDeserializer.Related Issue
#840
Motivation and Context
Flood doesn't display the original error returned back from rtorrent, and any useful context that the original error message may provide is lost.
How Has This Been Tested?
Haven't tested it yet, just proposing changes.
Screenshots (if appropriate):
Types of changes
Checklist: