[WIP] fix planning a very small battery (1W) #1421
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 26, 2025 12:23
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Contributor
|
Can you say how we found this problem / what the motivation is to create the fix? |
Contributor
|
Thank you for creating the bug report in the form of a This doesn't appear to be a problem with units, but rather with a rounding error. I haven't found the exact cause yet, but I'm pushing a dev commit to support my claim. So far, it only appears to be a problem in case of very small consumption capacity (<1.000000000000001 W) in combination with a soc-usage equal to the consumption capacity, which I'd argue is a very rare case. |
Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After a long time debugging, I realized why my schedules were infeasible: the magnitude of the quantities being used. The same problem scaled up by 1000 worked, but not in the original scale. This PR aims at fixing this issue, starting by introducing a test case that fails.