fix: load JSON fields #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F.N. Claessen <felix@seita.nl>
Contributor
Author
|
@copilot fix the linting and tests. Since this is currently a breaking change, I need you to adapt |
Contributor
#165) * Initial plan * Add parse_json_fields parameter to asset and sensor methods Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com> * Address code review feedback: add logging and use helper function Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com> * Improve code: use lazy logging and consistent parsing logic Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com> * Fix edge case handling and improve test formatting Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com> * Add proper error handling for JSON parsing in custom scheduler Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com> * Improve comment clarity for defensive programming Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com> * style: flake8 Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: F.N. Claessen <felix@seita.nl> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com> Co-authored-by: F.N. Claessen <felix@seita.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #165 for full details.