Draft
Conversation
Owner
|
Hello and first off, thank you so much for contributing! I am in the process of updating my workflow to the latest version of tModloader, as I haven't touched the repo in a while, but once I have it up and running I will have a proper review of the changes here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I have done the following things:
I have replaced all mod.BuffType, mod.ItemType with ModContent.BuffType
-tModloader (v 0.11.6.2) it would not build without this change
I have made quite a few changes to the config system. It now uses tModloader's ModConfig Class instead of Terraria's Preference class.
-tModloader can automatically sync ModConfigs between the server and client, and force the client to reload if needed. This means if the server has chosen to disable everything except base content, the client will automatically haave the same settings
This is a draft as it still needs at least the following things:
-The ability to convert from the old config to the new ones
-The WeaponOut_Custom still uses preferences, and could use similar ModConfig treatment
Of course, I'm open to suggestions and feedback.