-
Notifications
You must be signed in to change notification settings - Fork 423
Support Qwen & Llama #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Qwen & Llama #588
Conversation
Signed-off-by: ldwang <ldwang@baai.ac.cn>
Signed-off-by: ftgreat <ftgreat@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ftgreat, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly expands the framework's capabilities by integrating support for Qwen and Llama large language models. It provides new examples and necessary infrastructure for pre-training and generating text with these models. Additionally, it includes refinements to the existing AltDiffusion example, improving its training efficiency and robustness, and addresses a minor fix in the training environment setup.
Highlights
- New Model Support: Introduced comprehensive support for Qwen and Llama models, including dedicated example scripts for training and generation.
- AltDiffusion Improvements: Enhanced the AltDiffusion example with automatic mixed precision (AMP) training and a bug fix for device compatibility during loss calculation.
- AutoLoader Expansion: Updated the
AutoLoaderto seamlessly integrate and load Qwen3 and Llama3 models from the Hugging Face Transformers library. - Training Infrastructure Updates: Added new scripts and configurations for multi-GPU training and local execution for Llama models, leveraging
bmtrain.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Qwen and Llama models, including pre-training, generation scripts, and necessary updates to the model loader. It also includes some modifications to an existing AltDiffusion example. My review focuses on improving code quality, fixing potential bugs, and addressing a critical security vulnerability. Key feedback includes correcting the usage of torch.cuda.amp.autocast, removing dead code and unused imports, replacing a dangerous eval() call, and improving maintainability by reducing code duplication and removing hardcoded values.
name: Pull Request
title: '[PR]'
assignees: 'BAAI-OpenPlatform,ftgreat'
Description
Please describe here what the PR does.
Checklist