Update from Second Life Server 2024-09-13.10853867644#2
Open
otoa-kiyori wants to merge 8 commits intoFixedBit:masterfrom
Open
Update from Second Life Server 2024-09-13.10853867644#2otoa-kiyori wants to merge 8 commits intoFixedBit:masterfrom
otoa-kiyori wants to merge 8 commits intoFixedBit:masterfrom
Conversation
Extracted from llsd_keyword*.xml
Updated builtins_txt.com
Updated creator_wwin64.bat to use VS2022 C++ build
+ GLTF Overriding Functions + Link Material Function + Terrain Texture Functions + DEREZ_TO_INVENTORY
+ llSetParcelForSale()
There was a problem hiding this comment.
Pull Request Overview
This PR updates the lslint repository with Second Life Server changes from 2024-09-13. The changes include:
- Updates to LSL built-in functions and constants to match the latest Second Life Server specifications
- Build system improvements for Visual Studio 2022 compatibility
- Updated documentation reflecting the changes and new build requirements
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lslmini.y | Removes verbose parser error definition line |
| creator_win64.bat | Updates build script for Visual Studio 2022 compatibility |
| builtins_txt.cc | Comprehensive update of LSL built-in functions and constants |
| builtins.txt | Comprehensive update of LSL built-in functions and constants (source file) |
| README.md | Updates documentation for VS2022 build requirements and acknowledgments |
Comments suppressed due to low confidence (1)
lslmini.y:1
- Removing the verbose parser error configuration may reduce debugging capabilities. Consider documenting why this line was removed or if it should be replaced with an alternative error handling mechanism.
%{
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| exit /b 1 | ||
| ) | ||
| ) | ||
| echo "You do not appear to have Visual Studio 2022 (x64) Installed" |
There was a problem hiding this comment.
The comment on line 6 still mentions VS2017 but the code now checks for VS2022. Update the comment to match the actual functionality being performed.
| #### Additional changes | ||
| ##### Otoa | ||
| * updated the creator_win64.bat to use VSCode 2022 (I did not touch any other build scripts... sorry) | ||
| * updated builtins.txt and builtins_txt.cc with Second Life Server 2024-12-17 |
There was a problem hiding this comment.
There's an inconsistency between the PR title which mentions '2024-09-13' and this line which mentions '2024-12-17'. The dates should be consistent throughout the documentation.
Suggested change
| * updated builtins.txt and builtins_txt.cc with Second Life Server 2024-12-17 | |
| * updated builtins.txt and builtins_txt.cc with Second Life Server 2024-09-13 |
Comment on lines
+1
to
4
| All heavy lifting was done by FixedBit-san, Makapoo-san, and who they worked with in the repo history | ||
| This is just a clone with my lazy updates mainly on builtin.txt and builtin_txt.cc | ||
| Please see the original repo - [FixedBit/lslint](https://github.com/FixedBit/lslint) | ||
|
|
There was a problem hiding this comment.
[nitpick] This introduction significantly changes the project's presentation and may confuse users about the repository's purpose and maintenance status. Consider providing clearer information about the relationship to the original repository and the scope of changes.
Suggested change
| All heavy lifting was done by FixedBit-san, Makapoo-san, and who they worked with in the repo history | |
| This is just a clone with my lazy updates mainly on builtin.txt and builtin_txt.cc | |
| Please see the original repo - [FixedBit/lslint](https://github.com/FixedBit/lslint) | |
| ## About this repository | |
| This repository is a fork of [FixedBit/lslint](https://github.com/FixedBit/lslint), originally developed by FixedBit, Makapoo, and other contributors. The primary purpose of this fork is to provide updates to builtins.txt, builtins_txt.cc, and to add support for newer build environments and features. | |
| **Note:** This fork is not the original repository. For the canonical version and full project history, please visit [FixedBit/lslint](https://github.com/FixedBit/lslint). | |
| **Maintenance status:** This fork is maintained on a best-effort basis, with updates contributed as needed by the community. See the "Additional changes" section below for a summary of modifications and enhancements made in this fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope this is somewhat useful