Fix bottom white space#35
Fix bottom white space#35Axrorxoja wants to merge 1 commit intoFirebaseExtended:masterfrom Axrorxoja:fix/remove_bottom_white_space_in_preview
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
| if (childHeight <= layoutHeight) { | ||
| for (int i = 0; i < getChildCount(); ++i) { | ||
| getChildAt(i).layout(0, 0, childWidth, childHeight); | ||
| getChildAt(i).layout(0, 0, childWidth, getHeight()); |
There was a problem hiding this comment.
IIRC matching container's height forcibly will cause the camera frame distortion if the aspect ratio of camera preview is different than the container. For example, camera ratio is 16 : 9 and container ratio is 17 : 9, then this change will stretch the camera frame to have ratio 17 : 9.
No description provided.