Skip to content

Conversation

@0Tech
Copy link
Contributor

@0Tech 0Tech commented Mar 27, 2024

Description

This patch would update CoinType from the original value to 438.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@0Tech 0Tech self-assigned this Mar 27, 2024
@codecov
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (fnsad-v050-legacy@f3545a0). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##             fnsad-v050-legacy     #345   +/-   ##
====================================================
  Coverage                     ?   71.15%           
====================================================
  Files                        ?        8           
  Lines                        ?     1418           
  Branches                     ?        0           
====================================================
  Hits                         ?     1009           
  Misses                       ?      378           
  Partials                     ?       31           
Files Coverage Δ
app/ante.go 58.13% <ø> (ø)
app/test_support.go 0.00% <ø> (ø)
app/test_helpers.go 61.11% <0.00%> (ø)
app/app.go 88.20% <50.00%> (ø)
app/export.go 9.81% <0.00%> (ø)

@0Tech
Copy link
Contributor Author

0Tech commented Mar 27, 2024

Ignore CI failures for now. It would be addressed by #343.

@0Tech 0Tech marked this pull request as ready for review March 27, 2024 12:51
@tkxkd0159
Copy link
Member

tkxkd0159 commented Apr 1, 2024

Ignore CI failures for now. It would be addressed by #343.

@0Tech Is E2E-IBC okay to fail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants