Skip to content

Conversation

@leannecornish-ft
Copy link
Contributor

@leannecornish-ft leannecornish-ft commented May 1, 2025

Describe your changes

  1. We have found a bug that causes users that have previously had an FT account to comment with their old coral account. We will be adding an additional check to the auth endpoint in next-comments-api, which will return a 403 when an old coral account is found. This PR checks for this status and returns a user-friendly error to the client.
Screenshot 2025-05-01 at 16 29 41
  1. There's also some refactoring to make it more performant and easier to understand
  2. There's a bug fix to close the modal properly as it was preventing it being reopened

Additional context

JIRA ticket Figma design
Parent: CI-2823
Sub: CI-2827

Checklist before requesting a review

  • I have applied percy label for o-[COMPONENT] or chromatic label for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md
  • If it is a new feature, I have added thorough tests.
  • I have updated relevant docs.
  • I have updated relevant env variables in Doppler.

@leannecornish-ft leannecornish-ft mentioned this pull request May 1, 2025
4 tasks
@notlee notlee temporarily deployed to origami-webs-ci-2827-us-ukmkca May 1, 2025 16:30 Inactive
@leannecornish-ft leannecornish-ft force-pushed the ci-2827-user-error-handling branch from aafc365 to 23db9dc Compare May 2, 2025 10:09
@notlee notlee temporarily deployed to origami-webs-ci-2827-us-ukmkca May 2, 2025 10:09 Inactive
@leannecornish-ft leannecornish-ft force-pushed the ci-2827-user-error-handling branch from 23db9dc to cff4627 Compare May 2, 2025 10:15
@notlee notlee temporarily deployed to origami-webs-ci-2827-us-ukmkca May 2, 2025 10:15 Inactive
@leannecornish-ft leannecornish-ft marked this pull request as ready for review May 2, 2025 10:21
@leannecornish-ft leannecornish-ft requested a review from a team as a code owner May 2, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants