Conversation
Contributor
olusoladavid
left a comment
There was a problem hiding this comment.
Hi @asugar13 ,
Thanks for reporting this. Could you further describe the scenario where this was happening? Is it when you run smoke tests locally or does it happen in CI too? The TNavigationData type suggests that we don't expect this property to be sometimes optional, so would be nice to understand the root cause of the issue you're seeing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds optional chaining inside
packages/dotcom-ui-header/src/components/top/partials.tsx. This is used as a safe check so that smoke tests can run when using dotcom-tool-kit/n-test. This issue was found while working on the this ticket: https://financialtimes.atlassian.net/browse/LIF-977Without this change, the following error happens:
Checklist
Please read the contributing guidelines. In particular, please make sure:
main(don't mergemaininto your branch)