[NOT COMPLETE] Refactor codebase #209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed UserProfile.files to UserProfile.viewed_notes -- may not have fixed this in all places
Some very messy naming still exists in utils.py and forms.py. for example:
file = Note.objects.all()
At this point I ran the following forwards migration, and things are working. suspect there are a lot of bugs still
still # Removing M2M table for field tags on 'File'
db.delete_table('notes_file_tags')
# Adding M2M table for field tags on 'Note'
db.create_table('notes_file_tags', (
('id', models.AutoField(verbose_name='ID', primary_key=True, auto_created=True)),
('note', models.ForeignKey(orm['notes.note'], null=False)),
('tag', models.ForeignKey(orm['notes.tag'], null=False))
))
db.create_unique('notes_file_tags', ['note_id', 'tag_id'])
# Changing field 'Vote.note'
db.alter_column('notes_vote', 'note_id', self.gf('django.db.models.fields.related.ForeignKey')(to=orm['notes.Note']))
# Changing field 'ReputationEvent.file'
db.alter_column('notes_reputationevent', 'file_id', self.gf('django.db.models.fields.related.ForeignKey')(to=orm['notes.Note'], null=True))
…is as an attribute" This reverts commit d25db88.
… Renaming related name of user and target in ReputationEvent. cleaning references. fixes #164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.