Skip to content

Conversation

@mcpherrinm
Copy link
Contributor

While ACME is usually a good option, it's not always available.

This makes the ACME section optional and provides an alternative TLS section with a cert and key file.

While ACME is usually a good option, it's not always available.
@mcpherrinm
Copy link
Contributor Author

mcpherrinm commented Jan 20, 2024

I see the race detector firing on the previous commit, so it's unrelated to this PR (edit: merged the fix in from main)

@FiloSottile
Copy link
Owner

I am not a fan of supporting certificate loading without an option to rotate it, and implementing SIGHUP machinery for tests feels overkill. A pattern I use in these cases is adding a -testcert flag which reads from a couple of hardcoded paths, which makes it inconvenient enough to discourage production use. How's #5?

@mcpherrinm
Copy link
Contributor Author

That’s fine by me. I haven’t seen that pattern before but it makes sense.

@mcpherrinm mcpherrinm closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants